"Delete" for the media modal

[nacin]

Good to have: "Delete" actually deletes the attachment.

Less important but still nice to have: "Edit" opens post.php in a new screen.

[merty]

This seems to be the only way but naturally, & is being replaced with &

[miqrogroove]

I have concerns about this patch. It doesn't include the JS confirmation prompt or any kind of AYS feature. It also seems strange to navigate away from a modal window just to delete one image.

[miqrogroove]

Patch is broken anyway. It sends me to

/wp-admin/post.php?action=delete&post=118&_wpnonce=f731a7d735

and displays "Please try again."

[merty]

Replying to miqrogroove:

I have concerns about this patch. It doesn't include the JS confirmation prompt or any kind of AYS feature. It also seems strange to navigate away from a modal window just to delete one image.

You're right, added the prompt.

Replying to miqrogroove:

Patch is broken anyway. It sends me to

/wp-admin/post.php?action=delete&post=118&_wpnonce=f731a7d735

and displays "Please try again."

See my first comment above: "This seems to be the only way but naturally, & is being replaced with &"

This is what can be done if we just use what we currently have. The correct way of doing the deletion is to write a JS function to handle it which triggers the deletion and removes the item from the grid, without navigating away from the modal window.

[merty]

This must be the proper way to do it

[merty]

Just figured out the way the media modal works, sorry for the mess :)

22524.3.patch implements both of the functionalities mentioned, except it does not remove it from the grid. Will add that as well, once I figure out the best way to do it.

[koopersmith]

We should handle the deletion via an ajax request. Editing should be handled through a link with target="_blank" and the link should be properly processed in the PHP, not the JS.

[nacin]

No one has been clamoring for image editing. Since we would be opening a new window but not refreshing the attachment details in the open modal in the original window, let's leave "Edit" for when image editing it is integrated into the dialog in a future release.

Attached patch implements Delete Permanently and also makes the save-attachment nonces attachment-specific. The link doesn't quite line up with the dimensions, that's about the only issue.

[koopersmith]

22524.3.diff​ builds off of 22524.2.diff​:

• Adds CSS to align the delete link.
• Only shows the delete link when the attachment has uploaded. This prevents a race condition between the attachment removal and the upload request.
• Prevents get/save/delete attachment requests from running if the attachment doesn't have an id.

[ryan]

media-models.js needs refresh.

[ryan]

In 22869:

Add a delete link to the media modal.

Props merty, nacin, koopersmith
fixes #22524

[ryan]

Refreshed media-models.js to resolve patch conflict with [22865]. Double check that work.

[SergeyBiryukov]

#22620 was marked as a duplicate.