WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#22527 closed defect (bug) (fixed)

Menu icons are off by 1px

Reported by: lessbloat Owned by: nacin
Milestone: 3.5 Priority: normal
Severity: normal Version:
Component: Menus Keywords: has-patch
Focuses: Cc:

Description

Props to Nacin for catching this. The menu icons are all down 1px from 3.4, and look off.

Attachments (6)

22527.diff (22.4 KB) - added by lessbloat 6 years ago.
22527.2.diff (20.6 KB) - added by lessbloat 6 years ago.
22527.3.diff (10.2 KB) - added by lessbloat 6 years ago.
22527.4.diff (11.4 KB) - added by lessbloat 6 years ago.
menu.png (9.0 KB) - added by lessbloat 6 years ago.
menu-2x.png (29.6 KB) - added by lessbloat 6 years ago.

Download all attachments as: .zip

Change History (13)

@lessbloat
6 years ago

#1 @lessbloat
6 years ago

22527.diff should do the trick. I also centralized this code in wp-admin.css. There is no need (that I can think of) to have this code in the color's css.

#2 @nacin
6 years ago

It's worth doing this in two separate patches/commits, otherwise it's impossible to tell what changed.

I'd like to just fix the pixels now, and centralize in 3.6.

Needs testing in these modes, too: manual collapse, auto-fold collapse, and HiDPI.

@lessbloat
6 years ago

@lessbloat
6 years ago

#3 @lessbloat
6 years ago

22527.2.diff​ moves the source back to the color files, but keeps the background-position settings in wp-admin.css

22527.3.diff just fixes the icon positioning (in both color files).

#4 @lessbloat
6 years ago

  • Keywords has-patch added

#5 @nacin
6 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 22767:

Move the admin menu icons up one pixel, to restore their 3.4 positioning. props lessbloat. fixes #22527.

@lessbloat
6 years ago

@lessbloat
6 years ago

@lessbloat
6 years ago

#6 @lessbloat
6 years ago

22527.4.diff:​

  • reverts 22767
  • Adjusts icon alignment in sprites instead
  • Fixes "generic" icon alignment to match the rest
  • Fixes HiDPI generic icon alignment so that it doesn't jump 1px on hover

#7 @nacin
6 years ago

In 22785:

Revert [22767] and fix icon alignment issues in the sprites themselves. props lessbloat. fixes #22527.

Note: See TracTickets for help on using tickets.