PHP notices when inserting images

[miqrogroove]

Using WP 3.5-RC1, Chrome 23, and WinXP, I found that I could upload two images from QuickPress on the first try, but when I clicked the "Insert into post" button, the upload screen went away and the QuickPress textarea remained totally blank. This problem is repeatable.

[miqrogroove]

Correction, I can't insert images at all! I just switched to the post editor expecting that to solve the problem, but I still have a totally blank post after clicking Insert.

[miqrogroove]

Same problem in Firefox 16.
Same problem in Opera 12.
Same problem in IE8.
Confirmed with all plugins deactivated.

The only browser I have that can insert posts now is Safari on my iPad.

This needs to block RC2.

[johnbillion]

Confirmed. Clicking 'Insert into post' does nothing. Tested at r22829.

[SergeyBiryukov]

Could not reproduce yet neither in 3.5-RC1 nor in trunk. My steps:

1. Open post editor (or QuickPress).
2. Click "Add Media".
3. Upload an image, or select an existing one from Media Library tab.
4. Click "Insert into post".
5. The image appears in the post.

Tested in Firefox 17, Chrome 23, IE 8, Opera 12.

[miqrogroove]

I'm available for testing if you have any ideas about how to debug this.

[ocean90]

It's not a blocker until you can provide detailed steps to reproduce the issue. Currently I can't reproduce it.

[miqrogroove]

Okay ocean90, that doesn't help at all. What would you like me to do?

[miqrogroove]

I have partial debugging information.

In media-views.js

controller.state().trigger( 'insert', selection ).reset();

This line of code does not work. On my iPad it leads into the insert function in media-editor.js. On Windows, it doesn't seem to do anything at all.

[miqrogroove]

I'm brainstorming with azaozz on IRC. I've determined that in media-editor.js, this line is never executing:

wp.media.editor.insert( resp );

azaozz thinks it has to do with PHP errors being generated during ajax. I've got this showing up repeatedly in logs:

[23-Nov-2012 20:08:22] PHP Notice:  Undefined index:  url in /wp-admin/includes/ajax-actions.php on line 1945
[23-Nov-2012 20:08:22] PHP Notice:  Undefined variable: rel in /wp-admin/includes/ajax-actions.php on line 1951

[miqrogroove]

Confirmed, images can be inserted normally with DEBUG turned off.

[azaozz]

22553.patch fixes the PHP notices that show at the top of the ajax response and break it.

[miqrogroove]

IRC discussion has wrapped up. Patch tested and working. +1 commit

[nacin]

Includes fix for #22544.

[nacin]

Looking at this, I think we should go back to the old field names used by media_upload_form_handler() — align, image_alt, image-size, post_excerpt, post_title. Here's a patch that does that while fixing both this ticket and #22544.

[nacin]

Needs review and commit.

[nacin]

Refreshed 22553.diff​. Working well for me.

[miqrogroove]

Re-testing on 3.5-RC1-22844

Without any patch I get

[26-Nov-2012 17:23:45] PHP Notice:  Undefined index:  post_id in /wp-admin/includes/ajax-actions.php on line 1935
[26-Nov-2012 17:23:45] PHP Notice:  Undefined index:  url in /wp-admin/includes/ajax-actions.php on line 1950
[26-Nov-2012 17:23:45] PHP Notice:  Undefined variable: rel in /wp-admin/includes/ajax-actions.php on line 1956

With patch 22553.2.diff​ I get

[26-Nov-2012 17:32:24] PHP Notice:  Undefined index:  post_id in /wp-admin/includes/ajax-actions.php on line 1935

[miqrogroove]

Fixed with both patches:

​http://core.trac.wordpress.org/attachment/ticket/22553/22553.2.diff
​http://core.trac.wordpress.org/attachment/ticket/22085/22085.2.diff

[ryan]

In 22847:

In wp.media.editor:send, revert back to the old field names used by media_upload_form_handler() for easier back compat.
Fix notices in wp_ajax_send_attachment_to_editor().

Props nacin, azaozz, miqrogroove
fixes #22553