Opened 13 years ago
Closed 13 years ago
#22554 closed defect (bug) (fixed)
New media: Long file names overflow container
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Milestone: | 3.5 | Priority: | normal |
| Severity: | normal | Version: | 3.5 |
| Component: | Media | Keywords: | has-patch commit |
| Focuses: | Cc: |
Description
As per description.
Attachments (3)
Change History (16)
#1
in reply to:
↑ description
@
13 years ago
- Keywords reporter-feedback added
- Type changed from defect (bug) to feature request
#2
@
13 years ago
- Keywords reporter-feedback removed
- Type changed from feature request to defect (bug)
#3
@
13 years ago
- Keywords needs-patch added
Ah. This is due to removing the overflow: hidden; on the attachment view.
#7
follow-up:
↓ 9
@
13 years ago
Hello.
includes/css/media-views.css - line 561:
.attachment .filename {
/*...*/
overflow: hidden;
text-overflow: ellipsis;
}
This works, but imho this is not the best thing to do because we can see only 10 characters at best. I think this is a better way:
.attachment .filename {
/*...*/
overflow: hidden;
word-wrap: break-word;
max-height: 99px;
}
This way we can see longer file names. (the max-height is for veeeeeery long file names)
#8
@
13 years ago
Patch provides better handling for long filenames (no overflow, break word, fit within container, etc).
#9
in reply to:
↑ 7
@
13 years ago
- Keywords has-patch added; needs-patch removed
Replying to GregLone:
Hello.
Hi, GregLone, and welcome! In the future, instead of providing specific code changes in a comment, please create a patch. Patches make it much easier for other developers to apply and test your changes consistently.
I've converted some of your suggestions into a patch (with improvements to the max-height section, as the size of the grid is dynamic).
Replying to johnbillion:
Its nice hear about you,i am new here in this disscussions,
hope we good interaction in future wd eachother.
Many thnkx.