Cache invalidation in wp_set_object_terms

[batmoo]

In [21981], cache invalidation was added to wp_set_post_terms. Should this not actually go in wp_set_object_terms instead?

The current cache invalidation routine means that a call to wp_set_object_terms and then a subsequent call to get_the_terms will result in stale cache entry returned.

[batmoo]

Previous discussion that led to the change: ​http://core.trac.wordpress.org/ticket/21309#comment:72

[scribu]

The $taxonomy . '_relationships' cache is set in get_the_terms(), which only works for posts.

So, the cache is cleared in wp_set_post_terms(), which only works for posts.

[nacin]

I could see why this can be an issue. Many developers use wp_set_object_terms() for posts, probably not realizing the higher level function exists. I don't think there is any harm in clearing the cache at a lower point in the stack.

Correct me if I'm wrong, but this also isn't a regression? We didn't add caching, just invalidation. Or does the caching apply in new places that could cause issues?

[batmoo]

Replying to nacin:

Correct me if I'm wrong, but this also isn't a regression? We didn't add caching, just invalidation. Or does the caching apply in new places that could cause issues?

Not a regression but currently misleading since the expectation is that it's perfectly okay to use wp_set_object_terms in place of wp_set_post_terms and get the same outcome.

[nacin]

I don't think there is any harm in clearing the cache at a lower point in the stack.

I'll re-iterate my earlier statement.

[ryan]

​[UT1158]

[nacin]

If a taxonomy was assigned to completely different objects — say, a post and a user — and the same ID in both had a relationship cache, one would clear the other. This is acceptable, especially because that combination doesn't work anyway, as term relationships don't have a type of object — just an object ID and a tt ID.

Also, there is one early return in wp_set_object_terms() for db errors. We weren't doing a cache delete in wp_set_post_terms() for WP_Error either, so this also seems good.

[ryan]

In 22878:

Clear the object term relationships cache in wp_set_object_terms() rather than wp_set_post_terms(). This should be done lower in the stack than wp_set_post_terms().

Props batmoo
fixes #22560