WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#22578 closed defect (bug) (fixed)

'attachment_fields_to_edit' not fired from the new "Add media" modal

Reported by: Chouby Owned by: koopersmith
Milestone: 3.5 Priority: normal
Severity: normal Version: 3.5
Component: Media Keywords: has-patch commit
Focuses: Cc:

Description

in WP 3.5 RC1, if I directly upload file(s), the attachment details is displayed without fields created by 'attachment_fields_to_edit'

However, if I first go to the library, the fields are correctly displayed.

Attachments (1)

22578.diff (717 bytes) - added by koopersmith 3 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 @ocean903 years ago

  • Milestone changed from Awaiting Review to 3.5
  • Owner set to koopersmith
  • Status changed from new to reviewing

@koopersmith3 years ago

comment:2 @koopersmith3 years ago

  • Keywords has-patch added

Always render the attachment compat view, as it already handles the empty case.

comment:3 @nacin3 years ago

  • Keywords commit added

Tested, including logging the fired filters before and after. Thumbs up.

comment:4 @ryan3 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 22841:

Always render the attachment compat view. Assures attachment_fields_to_edit is always fired.

Props koopersmith, Chouby
fixes #22578

comment:5 @nacin3 years ago

#22629 was marked as a duplicate.

Note: See TracTickets for help on using tickets.