Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#22594 closed defect (bug) (fixed)

Media: Rename 'id' to 'state' in menu item view

Reported by: koopersmith Owned by: ryan
Milestone: 3.5 Priority: normal
Severity: normal Version: 3.5
Component: Media Keywords: has-patch commit
Focuses: Cc:


The MenuItem view leverages an id that is tied to the state that it will activate. However, a view's id is also tied to the id attribute on the element it creates, and we don't want to set that attribute, as multiple instances of media can exist on a page.

Attachments (1)

22594.diff (943 bytes) - added by koopersmith 4 years ago.

Download all attachments as: .zip

Change History (4)

#1 @koopersmith
4 years ago

  • Keywords has-patch added

4 years ago

#2 @nacin
4 years ago

  • Keywords commit added

#3 @ryan
4 years ago

  • Owner set to ryan
  • Resolution set to fixed
  • Status changed from new to closed

In 22851:

Rename 'id' to 'state' in menu item view.

Props koopersmith
fixes #22594

Note: See TracTickets for help on using tickets.