WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 3 years ago

#22599 closed enhancement (fixed)

Show reviews in the plugin installer

Reported by: helen Owned by: helen
Milestone: 4.0 Priority: normal
Severity: normal Version:
Component: Plugins Keywords:
Focuses: administration Cc:

Description

Pretty much as it says. Add reviews to the API endpoint, and then allow them to be shown as a tab in the modal. Seems like users should be able to vet via reviews from the comfort of the admin, now that they exist.

Attachments (3)

22599.last-updated.png (10.5 KB) - added by SergeyBiryukov 3 years ago.
22599.diff (2.4 KB) - added by nacin 3 years ago.
Patch from tellyworth ripped from WordPress.org code (as in, needs work)
22599-css.diff (2.8 KB) - added by tellyworth 3 years ago.
Minor improvement on the last patch, inline styles moved to common.css

Download all attachments as: .zip

Change History (17)

#1 @helen
4 years ago

  • Reporter changed from helenyhou to helen

#2 @mordauk
3 years ago

Yes please :)

#3 @SergeyBiryukov
3 years ago

  • Milestone changed from Awaiting Review to WordPress.org

Looks like reviews need to be added to the API endpoint here first.

We could probably just display RSS feeds for now, but they only contain review titles and text. I guess we would also want to see ratings.

This ticket was mentioned in IRC in #wordpress-ui by helen. View the logs.


3 years ago

#5 follow-up: @leedman
3 years ago

Not only that - show the age of the last update, too. Terrible pulling up things that are years old.

Could it be added to filter out plugins not updated in x months? etc?

#6 in reply to: ↑ 5 @SergeyBiryukov
3 years ago

  • Focuses administration added

Replying to leedman:

Not only that - show the age of the last update, too.

We already show that in the modal: 22599.last-updated.png (source).

This ticket was mentioned in IRC in #wordpress-dev by helen. View the logs.


3 years ago

This ticket was mentioned in IRC in #wordpress-dev by tellyworth. View the logs.


3 years ago

@nacin
3 years ago

Patch from tellyworth ripped from WordPress.org code (as in, needs work)

@tellyworth
3 years ago

Minor improvement on the last patch, inline styles moved to common.css

This ticket was mentioned in IRC in #wordpress-dev by tellyworth. View the logs.


3 years ago

#10 @mordauk
3 years ago

The review break downs are currently clickable (as they are on WordPress.org): https://cloudup.com/cP89YgfE6P2

This results in the repo page being loaded in a messy iframe: https://cloudup.com/cgbtoDi52uW

Could we either remove the links or have them show the filtered reviews in the the same way the first few are on load? https://cloudup.com/citqlBj2blG

#11 @stephdau
3 years ago

I've taken 22599-css.diff and made it part of the work being done on #27440.
I've taken mordauk's comment about the link in consideration.

tellyworth: the wp.org API should check that array_sum( (array) $api->ratings ) > 0, not just ! empty( $api->ratings ), before returning a reviews tab in the generated content markup. Otherwise, we end up displaying a tab with nothing in it.

Last edited 3 years ago by stephdau (previous) (diff)

#12 @stephdau
3 years ago

tellyworth: nevermind about reviews and array_sum() in API, I was able to hide the tab on the client-side. It's still unlikely to be of any value to return $api->ratings if 0 == array_sum( $api->ratings ) though.

#13 @helen
3 years ago

  • Milestone changed from WordPress.org to 4.0

#14 @helen
3 years ago

  • Owner set to helen
  • Resolution set to fixed
  • Status changed from new to closed

In 29040:

Improvements to the plugin information modal:

  • Show the banner image when available.
  • Show contributors and ratings breakdown in the FYI box.
  • Show reviews in a tab.

props stephdau, tellyworth, paulwilde, michalzuber. see #27440. fixes #19784, #22599, #26202.

Note: See TracTickets for help on using tickets.