WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#22606 closed defect (bug) (fixed)

Customizer: "Select a file" link cannot be opened from keyboard

Reported by: SergeyBiryukov Owned by: markjaquith
Milestone: 3.6 Priority: normal
Severity: normal Version:
Component: Accessibility Keywords: has-patch
Focuses: Cc:

Description

"Select a file" link in Background Image section doesn't work when trying to open it from keyboard (pressing Enter does nothing). Tested in Firefox 17 and Chrome 23.

First reported in #21283, see ticket:21283:55 (item 4). See also ticket:21283:67 (item 1).

Attachments (2)

customize-controls.js.diff (550 bytes) - added by adamsilverstein 5 years ago.
22606.patch (558 bytes) - added by SergeyBiryukov 5 years ago.

Download all attachments as: .zip

Change History (9)

#1 @sabreuse
5 years ago

Confirmed in FF & Chrome on both Mac & Linux

#2 @nacin
5 years ago

According to koopersmith, this is not an easy fix: "Plupload's shimming it, so we have to pass the event through. I thought it was only broken in html5less browsers, though..."

#3 @adamsilverstein
5 years ago

i created a patch that fires a click event when the user hits enter on the link (attached) - a bit of a kludge perhaps, but does make the page accessible, tested in both firefox and chrome on my mac.

#4 @adamsilverstein
5 years ago

  • Cc ADAMSILVERSTEIN@… added
  • Keywords has-patch added

#5 follow-up: @SergeyBiryukov
5 years ago

  • Milestone changed from Awaiting Review to 3.6

Seems good to me.

Refreshed with proper path and tabs instead of spaces (per WordPress Coding Standards).

#6 in reply to: ↑ 5 @adamsilverstein
5 years ago

Replying to SergeyBiryukov:

Seems good to me.

Refreshed with proper path and tabs instead of spaces (per WordPress Coding Standards).

ah yes, thanks for fixing that for me!

#7 @markjaquith
5 years ago

  • Owner set to markjaquith
  • Resolution set to fixed
  • Status changed from new to closed

In 23399:

Allow Backround Image's "select a file" link to be activated by pressing return on the keyboard.

props adamsilverstein. fixes #22606

Note: See TracTickets for help on using tickets.