WordPress.org

Make WordPress Core

#22609 closed defect (bug) (fixed)

IE7 + Media

Reported by: nacin Owned by: nacin
Milestone: 3.5 Priority: normal
Severity: normal Version:
Component: Media Keywords: audit has-patch commit
Focuses: Cc:

Description

See #22446. There are a few remaining issues for IE7. Are these insurmountable? Are these worth it? Should we just serve the same experience we'd serve as if you had JS disabled (no "Add Media"?).

Attachments (2)

22609.diff (469 bytes) - added by lessbloat 17 months ago.
22609.2.diff (660 bytes) - added by lessbloat 17 months ago.

Download all attachments as: .zip

Change History (9)

lessbloat17 months ago

comment:1 lessbloat17 months ago

I went through and retested everything in IE7.

My IE7 checklist:

  • Open media modal - works
  • Modal closes - works
  • Check and dash icons - don't show up, but that should be fixed by #22610
  • Upload image - works
  • Insert uploaded image - works
  • Browse media library - works
  • Search media library - works
  • Filter media library - works
  • Insert batch (edit link) - works
  • Reorder images (drag and drop) - works
  • Insert single - works
  • Delete permanently - works
  • From URL upload - works
  • Setting alignment - works
  • Setting caption - works
  • Multiple image selection - works
  • Create new gallery - works
  • Add gallery caption - works
  • Upload additional image to gallery - works
  • Change gallery settings - works
  • Inserting gallery - works

As far as I can see, everything now works in IE7.

2 minor changes in 22609.diff:

  • Fixed gallery view layout
  • Fixed alignment for attachment properties (in right column)
Last edited 17 months ago by lessbloat (previous) (diff)

comment:2 follow-up: nacin17 months ago

ie.css isn't going to be loaded on the frontend.

To confirm, these are no longer an issue?

  1. IE 7 needs some attention for the gallery view, see ticket:22446:22446.ie7_gallery.png
  1. IE 7 doesn't display the selected images (ticket:22446:22446.ie7_selected_images.png)
  1. In IE 7 Embed from URL doesn't work. Nothing happens after inserting an URL.

lessbloat17 months ago

comment:3 lessbloat17 months ago

22609.2.diff​ has 3 CSS hacks which will just target IE7, and work on both the front-end and in the admin. Can't think of any other way to do this at the moment. Suggestions?

comment:4 in reply to: ↑ 2 lessbloat17 months ago

Replying to nacin:

ie.css isn't going to be loaded on the frontend.

To confirm, these are no longer an issue?

  1. IE 7 needs some attention for the gallery view, see ticket:22446:22446.ie7_gallery.png

This is fixed for me with 22609.2.diff​

  1. IE 7 doesn't display the selected images (ticket:22446:22446.ie7_selected_images.png)

We can fix this, but it will add a load of CSS hacks to the media-view.css file. Since it doesn't really break major functionality for users, I'd vote to leave it out for IE7.

  1. In IE 7 Embed from URL doesn't work. Nothing happens after inserting an URL.

Works for me.

comment:5 nacin17 months ago

  • Keywords has-patch commit added

comment:6 ocean9017 months ago

Looks good.

comment:7 nacin17 months ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 22894:

Some IE7 CSS hacks for media to fix the gallery view. props lessbloat. fixes #22609.

Note: See TracTickets for help on using tickets.