WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#22610 closed defect (bug) (fixed)

Media Uploader Selected File Icons

Reported by: JerrySarcastic Owned by: ryan
Milestone: 3.5 Priority: normal
Severity: normal Version: 3.5
Component: Media Keywords: has-patch commit
Focuses: Cc:

Description

Icons to replace the unicode symbols in the new media uploader in 3.5 for selecting and deselecting images, as well as the close modal window (X) icon.

Attachments (21)

uploader-icons.zip (6.6 KB) - added by JerrySarcastic 2 years ago.
uploader-icons-2x.png (4.0 KB) - added by ocean90 2 years ago.
22610.diff (3.1 KB) - added by lessbloat 2 years ago.
uploader-icons.png (1.0 KB) - added by lessbloat 2 years ago.
uploader-icons-2x.2.png (2.4 KB) - added by lessbloat 2 years ago.
wp35-icons-new.jpg (464.2 KB) - added by JerrySarcastic 2 years ago.
2X icons in uploader
22610.2.diff (3.1 KB) - added by lessbloat 2 years ago.
uploader-icons-2.png (1.6 KB) - added by JerrySarcastic 2 years ago.
uploader-icons.optim.png (1.4 KB) - added by lessbloat 2 years ago.
uploader-icons-src.zip (39.9 KB) - added by JerrySarcastic 2 years ago.
Source PSD files for standard and 2x icons
22610.2.zip (5.1 KB) - added by lessbloat 2 years ago.
Zipped these up so it would be less confusing. These have both been optipng'd
22610.3.diff (4.7 KB) - added by helenyhou 2 years ago.
uploader-icons.2.png (2.3 KB) - added by JerrySarcastic 2 years ago.
uploader-icons-2x.3.png (6.1 KB) - added by JerrySarcastic 2 years ago.
Expands sprite to add X icons form gallery image removal
22610.4.diff (4.9 KB) - added by helenyhou 2 years ago.
uploader-icons.3.png (2.3 KB) - added by JerrySarcastic 2 years ago.
uploader-icons-2x.4.png (6.0 KB) - added by JerrySarcastic 2 years ago.
uploader-icons-scr.zip (51.3 KB) - added by JerrySarcastic 2 years ago.
uploader-icons-2x.5.png (6.6 KB) - added by JerrySarcastic 2 years ago.
uploader-icons.4.png (2.3 KB) - added by JerrySarcastic 2 years ago.
uploader-icons-src.2.zip (52.2 KB) - added by JerrySarcastic 2 years ago.
Fixes slight alignment issues (when compared to PNG files)

Download all attachments as: .zip

Change History (46)

comment:1 @SergeyBiryukov2 years ago

  • Version set to trunk

comment:2 @helenyhou2 years ago

These look nice, although of course need to see them in context. The 1x black dash seems a little fuzzier than the others, though.

@ocean902 years ago

@lessbloat2 years ago

@lessbloat2 years ago

comment:3 @JerrySarcastic2 years ago

Happy to iterate on the design, but the "fuzziness" looks better against the background. Here they are in context. :)

http://min.us/lNDhNv0GquziG

comment:4 @lessbloat2 years ago

22610.diff​ should get these mostly in place (may need a few pixel nudges).

uploader-icons.png​ & uploader-icons-2x.2.png​ have been imageoptim'd.

http://f.cl.ly/items/3B1k0U291V1o1r1p3P0c/media-icon-screenshots.png

Version 2, edited 2 years ago by lessbloat (previous) (next) (diff)

@JerrySarcastic2 years ago

2X icons in uploader

comment:5 @JerrySarcastic2 years ago

Oops, beat me to it Dave. :)

@lessbloat2 years ago

comment:6 @lessbloat2 years ago

22610.2.diff​ fixes alignment of gray icons slightly.

comment:7 @JerrySarcastic2 years ago

New 1x icons, as sharp as can be. :)

comment:8 @lessbloat2 years ago

uploader-icons.optim.png looks like:

http://f.cl.ly/items/1F0s1n1y3t2b2E0X2W3A/media-icons-gray-minus.png

comment:9 @helenyhou2 years ago

  • Milestone changed from Awaiting Review to 3.5

comment:10 @helenyhou2 years ago

  • Keywords has-patch needs-ui added; needs-patch removed

Need a source file for design/asset repo. If the 1x versions were hand-tweaked, please include those in the source file as well.

@JerrySarcastic2 years ago

Source PSD files for standard and 2x icons

comment:11 @JerrySarcastic2 years ago

  • Keywords needs-ui removed

@lessbloat2 years ago

Zipped these up so it would be less confusing. These have both been optipng'd

@helenyhou2 years ago

comment:12 @koopersmith2 years ago

As per IRC, JerrySarcastic is adding two x icons with the same treatment as the check and dash.

@JerrySarcastic2 years ago

Expands sprite to add X icons form gallery image removal

comment:13 @JerrySarcastic2 years ago

Should note: Both attached sprites expanded to add X icons. :)

@helenyhou2 years ago

comment:14 follow-up: @helenyhou2 years ago

22610.4.diff adds the x icon for removal of an item from the gallery edit view. Needs somebody to check on the icon placement in 2x for all of the above - ideally it would line up correctly so background-position doesn't need to be altered in the media query.

comment:15 @koopersmith2 years ago

  • Keywords commit added

These look lovely!

comment:16 @ryan2 years ago

Looking good on Retina MacBook.

comment:17 @ryan2 years ago

  • Owner set to ryan
  • Resolution set to fixed
  • Status changed from new to closed

In 22919:

Icons for select, deselect, and window close in the media modal.

Props JerrySarcastic, helenyhou, ocean90, lessbloat
fixes #22610

comment:18 @ryan2 years ago

In 22920:

Icons for select, deselect, and window close in the media modal.

Props JerrySarcastic, helenyhou, ocean90, lessbloat
fixes #22610

comment:19 @JerrySarcastic2 years ago

PNG files updated to fix image alignment of the remove (X) icons

comment:20 in reply to: ↑ 14 ; follow-up: @JerrySarcastic2 years ago

uploader-icons-2x.5.png​ fixed to center the remove (x) icon. Tested and works.

uploader-icons.4.png​ does the same, but needs to be tested.

comment:21 @SergeyBiryukov2 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

comment:22 in reply to: ↑ 20 @lessbloat2 years ago

Replying to JerrySarcastic:

uploader-icons-2x.5.png​ fixed to center the remove (x) icon. Tested and works.

uploader-icons.4.png​ does the same, but needs to be tested.

These look good on my Retina screen (I'm on the road, so I don't have a non-HiDPI screen to test on).

comment:23 @ryan2 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 22939:

Fix image alignment of the remove (X) icons in the media modal.

Props JerrySarcastic
fixes #22610

comment:24 @ryan2 years ago

In 22940:

ImageOptim for uplaoder icons. see #22610

@JerrySarcastic2 years ago

Fixes slight alignment issues (when compared to PNG files)

comment:25 @helenyhou2 years ago

Sources committed in [D11].

Note: See TracTickets for help on using tickets.