Make WordPress Core

Opened 11 years ago

Closed 11 years ago

#22611 closed defect (bug) (fixed)

Media modal: Don't fire two AJAX calls on settings update

Reported by: ocean90's profile ocean90 Owned by: ryan's profile ryan
Milestone: 3.5 Priority: normal
Severity: normal Version: 3.5
Component: Media Keywords: has-patch commit
Focuses: Cc:

Description

See media-views.js:3408

'change [data-setting]':             'updateSetting',
'change [data-setting] input':    'updateSetting',

Note by koop: should set a flag so one higher up doesn't fire.

Attachments (2)

22611.diff (828 bytes) - added by lessbloat 11 years ago.
22611.2.diff (737 bytes) - added by koopersmith 11 years ago.

Download all attachments as: .zip

Change History (8)

@lessbloat
11 years ago

#1 @lessbloat
11 years ago

Can we just remove the first one (see 22611.diff​)?

#2 @koopersmith
11 years ago

  • Keywords has-patch commit added; needs-patch removed

At this point, I'm okay with removing the first call.

#3 @koopersmith
11 years ago

  • Keywords has-patch commit removed

I lied, this will totally break stuff.

@koopersmith
11 years ago

#4 @koopersmith
11 years ago

  • Keywords has-patch commit added

Checks to see if an attachment setting changed before saving it.

#5 @ryan
11 years ago

Looks good.

#6 @ryan
11 years ago

  • Owner set to ryan
  • Resolution set to fixed
  • Status changed from new to closed

In 22907:

Media modal: Don't fire two AJAX calls on settings update.

Props koopersmith
fixes #22611

Note: See TracTickets for help on using tickets.