Media modal: Show a visual indication when settings will be saved

[ocean90]

Since it's not clear, that the new media modal saves the settings on the fly, we should add a visual indication whenever the settings are saved.

Patch is a beginning, feel free to continue.

[nacin]

Good start.

[lessbloat]

I wanted to see if I could get the spinner right next to each input in 22613-option-b.diff​. Not saying it's better - just another option.

[koopersmith]

To apply cleanly to trunk, both patches need the first chunk of media-views.js refreshed.

[lessbloat]

refreshing: 22613.refresh.patch, 22613-option-b.refresh.diff​​

[helenyhou]

I prefer 22613-option-b.refresh.diff%E2%80%8B, despite something that happened to the filename that makes Trac not highlight it :) Took me a while to find the spinner placed at the top - would probably not have noticed it if I wasn't looking.

In both cases the spinner does not go away if you've emptied the field, though it does seem to save the data successfully.

[koopersmith]

Patch implements the single-spinner variant, accounting for re-renders, multiple requests, and race conditions.

[helenyhou]

Works! Want to make sure it doesn't collide with the "Attachment Details" text in translations, though - does funky things if they don't fit next to each other.

[ryan]

In 22991:

Show a spinner when attachment details are saved.

Props koopersmith
see #22613

[ryan]

I inserted a huge string for Attachment Details and it seemed to handle it pretty well.

[ocean90]

Shouldn't we do this for the gallery view too? For the description field?

[helenyhou]

Probably totally unreasonable, but I managed to do this:

Fine with calling that a non-situation, though.

[ocean90]

With the updated UI I think we should change the place of the spinner since it can be hidden now.

We should place it in the top bar (near the X), so it can be shown for the gallery view too.

[helenyhou]

Testing 22613.4.diff​, logging in (or rather, switching to) the following users. I have categories enabled for attachments, which shows a compat field, and uploaded attachments as administrator and author users.

• Author (the important part)
  • Before: Can edit any field in all views but it won't actually save, although input will remain in the field for the duration of the page load for all views (not sure if this is desirable). User input does insert with the item.
  • After: When in the insert workflow, it is the same, except that category input is readonly for items not uploaded by the user. When in the gallery workflow, all fields are readonly except for those for items uploaded by the user, including inline caption field.

• Administrator and Editor
  • Before: can edit any field and it will save
  • After: same

• Contributor
  • Before: no access to the modal
  • After: same

[koopersmith]

Looks good. +1.

[markjaquith]

In 23072:

Intelligently make media fields readonly when the user cannot update or do anything with them. props koopersmith, helenyhou, nacin. fixes #22613