Context Navigation

← Previous Ticket
Next Ticket →

#22614 closed defect (bug) (fixed)

Right-clicking Press This broken if not WebKit or IE

Reported by:	trepmal	Owned by:	SergeyBiryukov
Priority:	normal	Milestone:	3.6
Component:	Press This	Version:	3.3
Severity:	normal	Keywords:	has-patch 3.6-early commit
Cc:		Focuses:

Description

Tested on 3.4.2 and 3.5-RC1.

In Firefox (or Opera…), right clicking on the Press This button does nothing.

It should allow the context menu to appear, giving the user a 'bookmark this link' option.

r18187 added a conditional and alternate functionality for IE and Webkit since they don't have that option. But the lack of braces causes return false; to run no matter what, preventing the context menu from appearing in Firefox.

Attachments (1)

22614.patch (3.4 KB ) - added by trepmal 14 years ago.: add braces

Download all attachments as: .zip

Change History (4)

@trepmal
14 years ago

Attachment 22614.patch added

add braces

#1 @SergeyBiryukov
14 years ago

Keywords 3.6-early commit added
Milestone Awaiting Review → Future Release

#2 @SergeyBiryukov
14 years ago

Milestone Future Release → 3.6

#3 @SergeyBiryukov
13 years ago

Owner set to SergeyBiryukov
Resolution → fixed
Status new → closed

In 23314:

Restore Press This context menu in Firefox and Opera. props trepmal. fixes #22614.

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core