Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#22615 closed defect (bug) (fixed)

Responsive css for the media modal

Reported by: azaozz Owned by:
Milestone: 3.5 Priority: low
Severity: normal Version: 3.5
Component: Media Keywords: audit needs-patch
Focuses: Cc:


The current goal is to make the new media modal work/look well on tablets and small-screen laptops (same as the rest of the admin).

Attachments (6)

22615.patch (2.3 KB) - added by azaozz 3 years ago.
22615-2.patch (2.3 KB) - added by azaozz 3 years ago.
22615.3.patch (438 bytes) - added by ocean90 3 years ago.
22615.4.diff (2.8 KB) - added by koopersmith 3 years ago.
22615.4b.diff (2.8 KB) - added by ocean90 3 years ago.
22615.5.diff (3.2 KB) - added by ocean90 3 years ago.

Download all attachments as: .zip

Change History (19)

@azaozz3 years ago

@azaozz3 years ago

comment:1 @azaozz3 years ago

In 22615-2.patch:

  • At 900px width reduces the width of the left and right areas and reorders the image options so labels ate above the fields.
  • 600px is the min-width. The modal has position: absolute so it can be scrolled horizontally.
  • Includes couple of fixes for In 22615.patch
Version 0, edited 3 years ago by azaozz (next)

comment:2 @nacin3 years ago

  • Keywords has-patch commit added

Good start.

comment:3 @koopersmith3 years ago

  • Keywords dev-feedback added

Concur. Commit, mark as see, bump to low priority.

comment:4 @koopersmith3 years ago

  • Keywords dev-reviewed added; dev-feedback removed

...things that begin with "dev".

comment:5 @koopersmith3 years ago

In 22887:

Responsive CSS for the media modal. props azaozz. see #22615, #21390.

comment:6 @koopersmith3 years ago

  • Keywords has-patch commit dev-reviewed removed
  • Priority changed from normal to low

@ocean903 years ago

comment:7 @ocean903 years ago

  • Keywords has-patch added

22615.3.patch improves the media selection in the toolbar.

@koopersmith3 years ago

comment:8 @koopersmith3 years ago

attachment:22615.4.diff builds off of​​ attachment:22615.3.patch:

Needs RTL after the current patch on #22453 is committed.

  • Tweaks media selection improvements, moves them to the earlier break point.
  • Adjusts modal size, dashed line position, separator size, padding on sidebar, and menu size.

@ocean903 years ago

@ocean903 years ago

comment:9 @ocean903 years ago

attachment:22615.5.diff​ adds a lot of RTL stuff. And refreshes 22615.4.diff​. And looks good.

(Except that the search form isn't bumped quickly enough.)

comment:10 @azaozz3 years ago

22615.5.diff looks good. The only thing I've noticed is the rounded search field in iOS, but that's the same as other search fields in the admin.

comment:11 @ryan3 years ago

In 22960:

Responsive and RTL css improvements or the media modal.

Props ocean90, koopersmith
see #22615

comment:12 @nacin3 years ago

  • Keywords audit needs-patch added; has-patch removed

This ticket is basically just open for any additional cleanups or adjustments we want to make; it's a rider.

comment:13 @nacin3 years ago

  • Resolution set to fixed
  • Status changed from new to closed

If ocean90 or azaozz has anything else here, please re-open. Thanks.

Note: See TracTickets for help on using tickets.