WordPress.org

Make WordPress Core

Opened 17 months ago

Closed 17 months ago

Last modified 17 months ago

#22621 closed defect (bug) (fixed)

New buttons: Clear recent list button misaligned

Reported by: johnbillion Owned by: nacin
Milestone: 3.5 Priority: normal
Severity: minor Version: 3.5
Component: UI Keywords: has-patch
Focuses: Cc:

Description

The 'Clear Recent List' button on the 'Recently Active' tabs of the Plugins screen is too small and is misaligned.

Attachments (4)

before.PNG (4.7 KB) - added by johnbillion 17 months ago.
22621.diff (1.1 KB) - added by johnbillion 17 months ago.
after.PNG (5.0 KB) - added by johnbillion 17 months ago.
22621.2.diff (1.2 KB) - added by SergeyBiryukov 17 months ago.

Download all attachments as: .zip

Change History (10)

johnbillion17 months ago

johnbillion17 months ago

johnbillion17 months ago

comment:1 johnbillion17 months ago

  • Keywords has-patch added

Patch

comment:2 nacin17 months ago

Removing .button-small handles most of it. #doaction, #doaction2 also has a top margin of 1px that seems like it should be removed.

SergeyBiryukov17 months ago

comment:3 ocean9017 months ago

Patch seems fine. Either remove the 1px margin from #doaction, #doaction2 and #clear-recent-list or add it to all.

comment:4 nacin17 months ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 22906:

Adjust size of the 'Clear List' list table button. Fix placement of other buttons next to bulk actions. props johnbillion, SergeyBiryukov, fixes #22621.

comment:5 SergeyBiryukov17 months ago

To be clear, 1px on those action buttons is to compensate for 1px on select:
http://core.trac.wordpress.org/browser/tags/3.4.2/wp-admin/css/wp-admin.dev.css#L321

#changeit comes from ticket:22034:22034-2.patch, which was merged with #delete_all in ticket:21598:21598-17.patch, but [22288] didn't include that part.

comment:6 SergeyBiryukov17 months ago

  • Milestone changed from Awaiting Review to 3.5
Note: See TracTickets for help on using tickets.