WordPress.org

Make WordPress Core

Opened 9 years ago

Closed 9 years ago

#22622 closed defect (bug) (fixed)

Route uploads through async-upload.php instead of admin-ajax.php

Reported by: koopersmith Owned by: ryan
Milestone: 3.5 Priority: high
Severity: major Version: 3.5
Component: Upload Keywords:
Focuses: Cc:

Description

wp.Uploader sends its uploaders to admin-ajax through the wp_ajax_upload_attachment() method instead of to async-upload. While the resulting code is cleaner, some installs may have async-upload whitelisted and/or provisioned differently than admin-ajax, resulting in errors (including but not limited to differing file size limitations).

After discussing in IRC, we're going to route everything through async-upload for 3.5.

Attachments (4)

22622.diff (1.6 KB) - added by nacin 9 years ago.
22622.2.diff (2.2 KB) - added by nacin 9 years ago.
22622.3.diff (2.9 KB) - added by koopersmith 9 years ago.
22622.4.diff (2.9 KB) - added by koopersmith 9 years ago.

Download all attachments as: .zip

Change History (8)

@nacin
9 years ago

@nacin
9 years ago

@koopersmith
9 years ago

#1 @koopersmith
9 years ago

Not working yet, but adds the code to make plupload send through async-upload.

@koopersmith
9 years ago

#2 @koopersmith
9 years ago

Working.

#3 @azaozz
9 years ago

22622.4.diff works well here too.

#4 @ryan
9 years ago

  • Owner set to ryan
  • Resolution set to fixed
  • Status changed from new to closed

In 22902:

Route uploads through async-upload.php instead of admin-ajax.php.

Props nacin, koopersmith
fixes #22622

Note: See TracTickets for help on using tickets.