WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#22627 closed defect (bug) (fixed)

Media swallows type attribute in gallery shortcodes

Reported by: ryan Owned by: ryan
Milestone: 3.5 Priority: normal
Severity: normal Version: 3.5
Component: Gallery Keywords: has-patch commit dev-reviewed
Focuses: Cc:

Description

If a plugin implements a "type" attribute for galleries, it doesn't work, because type is reserved for other things.

Attachments (1)

22627.diff (645 bytes) - added by koopersmith 3 years ago.

Download all attachments as: .zip

Change History (4)

@koopersmith3 years ago

comment:1 @koopersmith3 years ago

  • Keywords has-patch commit added

Retain all gallery shortcode attributes that do not map to query arguments.

comment:2 @nacin3 years ago

  • Keywords dev-reviewed added

Works.

comment:3 @ryan3 years ago

  • Owner set to ryan
  • Resolution set to fixed
  • Status changed from new to closed

In 22912:

In the gallery editor, don't stomp on custom shortcode attributes.

Props koopersmith
fixes #22627

Note: See TracTickets for help on using tickets.