WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#22628 closed defect (bug) (fixed)

Improve switching between browser and upload state

Reported by: koopersmith Owned by: ryan
Milestone: 3.5 Priority: normal
Severity: normal Version: 3.5
Component: Media Keywords: has-patch
Focuses: Cc:

Description

Currently, the attachments browser falls back to the upload state when there are no items in the collection. There are two major failings with the current implementation:

  1. When first navigating to the media library, you see a flash of the upload state before the attachments load.
  2. When a filter with no items is selected, we show an empty content area.

By moving the upload state and switching code into the browser view, we can fix both of these problems and eliminate complexity in the state.

Attachments (4)

22628.diff (4.2 KB) - added by koopersmith 2 years ago.
22628.filter.fix.png (75.4 KB) - added by koopersmith 2 years ago.
22628.2.diff (4.1 KB) - added by koopersmith 2 years ago.
22628.3.diff (4.3 KB) - added by koopersmith 2 years ago.

Download all attachments as: .zip

Change History (13)

@koopersmith2 years ago

comment:1 @koopersmith2 years ago

A nice touch after this would be to add spinners when attachments are loading.

Last edited 2 years ago by koopersmith (previous) (diff)

comment:2 @koopersmith2 years ago

This is what an empty filter looks like.

@koopersmith2 years ago

comment:3 @koopersmith2 years ago

Latest patch fixes vanishing view when switching back and forth.

comment:4 @ryan2 years ago

Looks good.

comment:5 @ryan2 years ago

  • Resolution set to fixed
  • Status changed from new to closed

This snuck in with [22919].

comment:6 @ryan2 years ago

In 22923:

Revert accidental bits from r22919. see #22628

comment:7 @ryan2 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

This caused some problems with creating and editing galleries.

@koopersmith2 years ago

comment:8 @koopersmith2 years ago

Ah. Gallery problems were caused because they didn't have a content mode set. Fixed in latest patch.

comment:9 @ryan2 years ago

  • Owner set to ryan
  • Resolution set to fixed
  • Status changed from reopened to closed

In 22945:

Improve switching between browser and upload state.

Props koopersmith
fixes #22628

Note: See TracTickets for help on using tickets.