media.view.MediaFrame.restoreThickbox() not called in all cases

[TobiasBg]

media.view.MediaFrame.restoreThickbox() is not called (and thus window.tbRemove() is not restored), when the new Media Manager is just closed (by clicking on the X or the gray border area). It is only called when the Media Manager is closed when something is inserted into the editor (e.g. "Insert into Post").

This breaks the closing behavior of other Thickboxes on the page, as tbRemove() is then not available.

[koopersmith]

Patch ensures modal events are always fired on its frame.

Easist way to test this is to open the modal, type tb_remove in a Webkit console (where it will display the source), close the modal, and type tb_remove again (or if you're feeling frisky, set them to variables and run an equality test). Did they output the same thing? No? Good.

[TobiasBg]

Confirmed, patch fixes the issue.

Note: The verb is "to propagate", I think.

[koopersmith]

Replying to TobiasBg:

Note: The verb is "to propagate", I think.

You are correct. Huh.

[koopersmith]

Now with better spelling!

[ryan]

In 22938:

In the media modal, ensure modal events are always fired on its frame. This ensures restoreThickbox() and thus tbRemove() are called properly when clicking the close button of the modal.

Props koopersmith
fixes #22632