Make WordPress Core

Opened 12 years ago

Closed 12 years ago

#22655 closed defect (bug) (fixed)

Properly pass WordPress uploading errors to wp.Uploader

Reported by: koopersmith's profile koopersmith Owned by: ryan's profile ryan
Milestone: 3.5 Priority: normal
Severity: normal Version: 3.5
Component: Media Keywords: has-patch
Focuses: Cc:

Description

Currently, the media modal spits out a very generic plupload error whenever we encounter an error on the PHP side. This should not be the case. We're not formatting the error object in exactly the right format — we're missing the 'data' property.

The easiest way to test is to recursively remove write access to your uploads directory, and then try to upload a file. If you see "An error occurred in the upload. Please try again later.", that's the generic error. If you see an error specific to the file, that's WP's response.

Attachments (2)

22655.diff (1.2 KB) - added by koopersmith 12 years ago.
22655.2.diff (1.9 KB) - added by koopersmith 12 years ago.

Download all attachments as: .zip

Change History (5)

@koopersmith
12 years ago

#1 @koopersmith
12 years ago

ocean90 pointed out that we should probably add some CSS to allow long filenames to break.

@koopersmith
12 years ago

#2 @koopersmith
12 years ago

Latest adds CSS to break words in errors and moves the max width from the error to the entire status div (to prevent huge progress bars).

#3 @ryan
12 years ago

  • Owner set to ryan
  • Resolution set to fixed
  • Status changed from new to closed

In 22954:

Properly pass WordPress uploading errors to wp.Uploader.

Props koopersmith
fixes #22655

Note: See TracTickets for help on using tickets.