WordPress.org

Make WordPress Core

Opened 8 years ago

Closed 8 years ago

#22662 closed defect (bug) (fixed)

No way to access Media Link while adding/editing Media

Reported by: vickybiswas Owned by: koopersmith
Milestone: 3.5 Priority: normal
Severity: normal Version: 3.5
Component: Media Keywords: has-patch
Focuses: Cc:

Description

There is no way to access the link(url) for a media file in the new Media UI.

Submitting a patch to do the same.

Attachments (5)

Capture.PNG (148.6 KB) - added by vickybiswas 8 years ago.
A shot of how the patch places the url
add media url to Add Media.patch (827 bytes) - added by vickybiswas 8 years ago.
Patch to add a url
22662.patch (475 bytes) - added by merty 8 years ago.
22662.png (51.4 KB) - added by merty 8 years ago.
22662.diff (1.5 KB) - added by nacin 8 years ago.

Download all attachments as: .zip

Change History (13)

#1 @batmoo
8 years ago

  • Cc batmoo@… added

#2 follow-up: @nacin
8 years ago

  • Version set to trunk

Can you please re-patch without touching the minified CSS? That isn't necessary, and will end up rendering the patch stale really quick (if anything else changes in the file). Thanks!

I've been thinking about this for some time. Is the URL necessary? I'm not sure where it should go. It's useful to have it there if you need it, but it really gets in the way if you don't. Maybe show it near the metadata (dimensions, name, file type, etc.), style it like text but make it a readonly input?

#3 @mintindeed
8 years ago

  • Cc gabriel.koen@… added

#4 in reply to: ↑ 2 @vickybiswas
8 years ago

The URL is indeed needed for various purposes. I have tried to put it in the place where it will least come in the way. Seems your idea matches what I have done. Uploading a screenshot along with the repatch.

Replying to nacin:

Can you please re-patch without touching the minified CSS? That isn't necessary, and will end up rendering the patch stale really quick (if anything else changes in the file). Thanks!

I've been thinking about this for some time. Is the URL necessary? I'm not sure where it should go. It's useful to have it there if you need it, but it really gets in the way if you don't. Maybe show it near the metadata (dimensions, name, file type, etc.), style it like text but make it a readonly input?

@vickybiswas
8 years ago

A shot of how the patch places the url

@vickybiswas
8 years ago

Patch to add a url

#5 @nacin
8 years ago

  • Component changed from General to Media
  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 3.5

This is great. Let's see if we can compress it a bit more with some CSS for this one field. (Patches welcome.) Assigning to koopersmith for eventual review.

#6 @nacin
8 years ago

  • Owner set to koopersmith
  • Status changed from new to assigned

@merty
8 years ago

@merty
8 years ago

#7 @merty
8 years ago

  • Cc merty92@… added

@nacin
8 years ago

#8 @ryan
8 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 22965:

In the media modal, show the Link To: url.

Props nacin
fixes #22662

Note: See TracTickets for help on using tickets.