![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
Opened 14 years ago
Closed 14 years ago
#22680 closed defect (bug) (fixed)
Check data.height and data.width before displaying dimensions
| Reported by: | nacin | Owned by: | nacin |
|---|---|---|---|
| Priority: | normal | Milestone: | 3.5 |
| Component: | Media | Version: | 3.5 |
| Severity: | normal | Keywords: | has-patch commit |
| Cc: | Focuses: |
Description
A .ico file has either image/vnd.microsoft.icon or image/x-icon as its mime type. (Likely the latter due to wp_get_mime_types(), even though the former is canonical.)
This means it thinks it is an image. But, it doesn't have stored dimensions because in PHP we don't process icon files. That ends up with an awkward, lonely '×' where the dimensions sit, and it looks like a removal button if anything.
There might need to be other checks for icons, but I'm not really concerned about those edge cases. Even wp_attachment_is_image() simply let's ^/image/ pass, despite also checking the extension.
Attachments (1)
Change History (4)
Note:
See TracTickets
for help on using tickets.
Looks sane. We might want to improve the check for
imagetypes to be more specific, but this is a good start.