WordPress.org

Make WordPress Core

Opened 9 years ago

Closed 9 years ago

#22689 closed defect (bug) (fixed)

Placeholder text is same color as actual text in Firefox

Reported by: helenyhou Owned by: nacin
Milestone: 3.5 Priority: normal
Severity: normal Version:
Component: Administration Keywords: has-patch
Focuses: Cc:

Description

I don't love targeting internal browser CSS, but in the case of placeholder text in Firefox, I think we need to. For example, in the media modal, "Describe this image..." is used as a placeholder but rather appears as though it's the user's input and is a bit confusing, especially because it doesn't disappear on focus.

Done both for the admin at large and for the media modal itself in the attached patch.

Attachments (2)

22689.diff (912 bytes) - added by helenyhou 9 years ago.
22689.2.diff (918 bytes) - added by helenyhou 9 years ago.

Download all attachments as: .zip

Change History (9)

@helenyhou
9 years ago

@helenyhou
9 years ago

#1 @nacin
9 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 22986:

In Firefox, style placeholder text a dark gray since the browser doesn't do it for us. props helenyhou, fixes #22689.

#2 @toscho
9 years ago

  • Cc info@… added

Note that Firefox will switch to `::-moz-placeholder` in version 19. That is not far away, I think we should use both selectors now for a while.

#3 @SergeyBiryukov
9 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

#4 follow-up: @helenyhou
9 years ago

Are we going to remember to remove one/both later, then? This is why I hate targeting this mess. We have :-moz-placeholder in a couple other places as well (color picker and toolbar). Maybe worth a separate ticket to address them all instead.

#5 in reply to: ↑ 4 @toscho
9 years ago

Replying to helenyhou:

Are we going to remember to remove one/both later, then?

I am updating this beast regularly, so I can promise not to forget it. :)

A separate ticket for all occurrences would probably be better, yes.

#6 @nacin
9 years ago

  • Keywords close added

According to MDN, they are "deprecating" it. I don't see it saying it will be "removed". Let's revisit in 3.6?

#7 @SergeyBiryukov
9 years ago

  • Keywords close removed
  • Resolution set to fixed
  • Status changed from reopened to closed

A separate ticket for all occurrences of :-moz-placeholder sounds good.

Note: See TracTickets for help on using tickets.