WordPress.org

Make WordPress Core

Opened 8 years ago

Closed 8 years ago

Last modified 7 years ago

#2271 closed defect (bug) (fixed)

fileupload_url not set when fileupload_realpath changed

Reported by: skeltoac Owned by: ryan
Milestone: Priority: high
Severity: major Version: 2.0
Component: Administration Keywords: bg|has-patch
Focuses: Cc:

Description

Not a problem if fileupload_url is empty, because wp_upload_dir() computes the url from the realpath. However, upgraders will be unable to upload if fileupload_url is set.

This patch sets fileupload_url to a computed value when fileupload_realpath is saved.

Attachments (2)

upload-url.diff (754 bytes) - added by skeltoac 8 years ago.
2271.diff (2.5 KB) - added by davidhouse 8 years ago.
Just drop fileupload_url

Download all attachments as: .zip

Change History (7)

skeltoac8 years ago

comment:1 ryan8 years ago

We should drop the fileupload_url option since we don't provide a way to change it. It is derived from fileupload_realpath.

davidhouse8 years ago

Just drop fileupload_url

comment:2 davidhouse8 years ago

As per Ryan's request. This will break people that have their uploads folder outside of their wordpress root (was allowed in 1.5), but that's getting too picky.

comment:3 ryan8 years ago

I have a slightly different patch that also changes the name of the upload path option so as to avoid interference from the old option. It also puts uploads in wp-content and turns off date dirs if safe_mode is on. safe_mode can screw up mkdir().

comment:4 ryan8 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [3437]) More upload path tweaks. fixes #2271

comment:5 anonymous7 years ago

  • Milestone 2.0.1 deleted

Milestone 2.0.1 deleted

Note: See TracTickets for help on using tickets.