Make WordPress Core

Opened 14 years ago

Closed 14 years ago

Last modified 14 years ago

#22715 closed defect (bug) (fixed)

No items found message in new media modal

Reported by: tomthewebmaster Owned by: nacin
Priority: normal Milestone: 3.5
Component: Media Version: 3.5
Severity: normal Keywords: has-patch commit
Cc: Focuses:

Description

When I was working in the new media modal, I discovered what seems to be an unintended message. To reproduce:

  • Click on an uploaded image
  • Press "Edit"
  • Press "Clear"

I received the message shown in the attached image, indicating "No items found." and an opportunity to upload new images. It doesn't seem one should be presented with a message to upload images in the "Media Library" area. It would be better if the user were returned to the media library.

Attachments (2)

22715.png​ (83.3 KB ) - added by tomthewebmaster 14 years ago.
22715.diff​ (492 bytes ) - added by koopersmith 14 years ago.

Download all attachments as: .zip

Change History (15)

#1 @tomthewebmaster
14 years ago

  • Summary No items found message in Media Modal → No items found message in new media modal

#2 @tomthewebmaster
14 years ago

  • Component General → Media

#3 @nacin
14 years ago

  • Version → trunk

#4 @lessbloat
14 years ago

Note: you're no longer able to see/click the edit button if you only have a single image selected. Nor can you any longer see the clear link when in bulk edit. However, you can replicate this by selecting multiple images, clicking edit, then clicking the "X" on each of the images.

#5 @koopersmith
14 years ago

  • Keywords has-patch commit added

Returns the user to the library when the editing a selection and no items are selected (as intended).

#6 @tomthewebmaster
14 years ago

I applied 22715.diff​ and am returned to Upload Files, not the Media Library.

#7 follow-up: @nacin
14 years ago

Testing with SCRIPT_DEBUG on?

#8 in reply to: ↑ 7 @tomthewebmaster
14 years ago

Replying to nacin:

Testing with SCRIPT_DEBUG on?

Yes.

#9 @tomthewebmaster
14 years ago

I applied the patch for #22718 (along with this patch (22715.diff​)), and now this is working correctly for me, too. I am now being returned to the Media Library. Not sure what was going on.

#10 @lessbloat
14 years ago

+1 to 22715.diff​. Works for me.

#11 @nacin
14 years ago

  • Owner set to nacin
  • Resolution → fixed
  • Status new → closed

In 23051:

Media: Return to the library when the editing a selection and all items get de-selected. props koopersmith. fixes #22715.

#12 @SergeyBiryukov
14 years ago

  • Milestone Awaiting Review → 3.5

#13 @nacin
14 years ago

Resulted in #22930.

Note: See TracTickets for help on using tickets.