WordPress.org

Make WordPress Core

#22722 closed defect (bug) (fixed)

Create Gallery Shouldn't Say "All media"

Reported by: miqrogroove Owned by: koopersmith
Milestone: 3.5 Priority: normal
Severity: normal Version: 3.5
Component: Media Keywords:
Focuses: Cc:

Description

I'm still extremely confused by the presence of the two different Library tabs in the new media modal. Here's a specific problem with them:

They both have an option called "All media items" that appear to do completely different things to the library view.

Attachments (2)

22722.diff (1.1 KB) - added by lessbloat 17 months ago.
22722.2.diff (904 bytes) - added by koopersmith 17 months ago.

Download all attachments as: .zip

Change History (15)

comment:1 helenyhou17 months ago

Galleries can only contain images, so I imagine that's what it's filtering. Perhaps the filter dropdown shouldn't say "All media items" but rather "Images".

It is actually much better for the user that they can only select items that can actually go into a gallery. Would be much worse if they could select audio or PDFs that won't show in the end result.

lessbloat17 months ago

comment:2 lessbloat17 months ago

22722.diff​ switches "All media items" to "All images" in the Gallery, and the Featured Image view.

Last edited 17 months ago by lessbloat (previous) (diff)

comment:3 koopersmith17 months ago

Two things. First, we should probably use just "Images", as the "add to gallery" library only shows images not in the gallery (so, not *all* images) and "All images" is a new string. Second, this view is not tailored for images alone (it just so happens that we use it with image queries), so "all images" may be inaccurate if applied directly to the view.

koopersmith17 months ago

comment:4 koopersmith17 months ago

  • Keywords has-patch needs-testing added

attachment:22722.2.diff uses the correct string based on the query's mime type and whether the mime type string is available.

comment:5 lessbloat17 months ago

  • Keywords needs-testing removed

+1 to 22722.2.diff​. Works well.

comment:6 koopersmith17 months ago

  • Keywords commit added

comment:7 nacin17 months ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 23041:

When adding images to a gallery, use "Images" as the filter name, rather than "All media items". props koopersmith. fixes #22722.

comment:8 pavelevap17 months ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Filter name "Images" should be also used in "Add to Gallery" tab for consistency?

comment:9 nacin17 months ago

  • Milestone changed from Awaiting Review to 3.5

comment:10 nacin17 months ago

  • Keywords has-patch commit removed

comment:11 nacin17 months ago

This should be fixed when #22723 is.

comment:12 nacin17 months ago

  • Owner changed from nacin to koopersmith
  • Status changed from reopened to assigned

comment:13 markjaquith17 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 23068:

Fix the "Uploaded to this post" filter in the "Add to gallery" state. fixes #22723

Also, use "images" wording instead of generic "media items" when in a gallery (images-only) context. fixes #22722

Both are props koopersmith

Note: See TracTickets for help on using tickets.