Opened 12 years ago
Closed 12 years ago
#22724 closed defect (bug) (fixed)
Context for Random and checkbox position
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 3.5 | Priority: | normal |
Severity: | normal | Version: | 3.5 |
Component: | Media | Keywords: | has-patch commit |
Focuses: | Cc: |
Description
We should have context for "Random", because its meaning was changed a little:
1) Order by: "Random" (one of dropdown options in Links widget)
2) "Random" - New checkbox for galleries (before it was also dropdown option).
And I am not sure if checkbox should be centered? See attached screenshot.
Attachments (7)
Change History (30)
#1
@
12 years ago
- Keywords has-patch i18n-change added
- Milestone changed from Awaiting Review to 3.5
#3
@
12 years ago
"Random" string was used in other situation for galleries in 3.4. It was also in dropdown widget, so suggested context change was not needed. But in 3.5 context was changed, so it is some kind of regression. Now there is not "Sorted by: Random" (so it can be asked How?), but only Random (a different meaning, noun). It is problem in my language, but may be also in other languages, I guess... But I am not sure, maybe we could ask some other users.
No problem waiting for 3.6, but there were too many changes after string freeze that it could also happen in 3.5.
#4
@
12 years ago
It's one string and it makes a difference. I vote for pushing it to 3.5 and warning the polyglots.
#5
@
12 years ago
- Owner set to nacin
- Resolution set to fixed
- Status changed from new to closed
In 23021:
#7
@
12 years ago
I had put out a request for comments here: http://make.wordpress.org/polyglots/2012/12/04/there-has-been-a-request-to-split-a/
#9
@
12 years ago
And what about checkbox position? Shoud be centered? Please see attached screenshot.
Or should I reopen this ticket?
#10
@
12 years ago
- Resolution fixed deleted
- Status changed from closed to reopened
22724.patch is an attempt to fix the checkbox position.
#12
@
12 years ago
There is already a .media-sidebar .setting input[type="checkbox"] {
rule specifying margin-top: 10px. Can we combine them?
#13
@
12 years ago
Please see attached screenshot.
There's no attached screenshot. When does this occur? It looks fine for me and koopersmith in Chrome.
#19
@
12 years ago
Checkbox is damaged in IE9. Could you please test it somebody? See attached screenshot.
#20
@
12 years ago
- Keywords has-patch i18n-change commit removed
- Resolution fixed deleted
- Status changed from closed to reopened
I guess IE must apply height to checkboxes. A little speechless.
#21
@
12 years ago
- Keywords has-patch added
22724.diff is about as consistent as I can get it. It sits a little low in Opera and a little lower yet in FF on OSX, but Chrome, IE, and FF on the PC all look great, which is to say the majority will see it looking pretty.
The "Random" string was used in the same situation in 3.4 — links widget and galleries. Can we get away with releasing 3.5 then splitting this string in 3.6? Are you asking because it is imperative to split this string in your language, or are you asking because other translators might need it?
Go with the translation for "Random" that makes sense for galleries. The Links widget instance is fairly well hidden, and the widget is disabled for new installs anyway.