Gallery Cleared Unexpectedly

[miqrogroove]

To reproduce:

1. Select images.
2. Click Create a new gallery.
3. Click Add to Gallery.
4. Click Cancel Gallery.

Compare to:

1. Select images.
2. Click Create a new gallery.
3. Click Add to Gallery.
4. Click Edit Gallery.
5. Click Cancel Gallery.

Depending on which page the user clicks Cancel Gallery, the image selection may or may not be preserved.

[miqrogroove]

Also: Any additions or edits made to the gallery will be reverted when clicking Cancel from the Edit page. So there are three different outcomes: Gallery preserved, gallery reverted, and gallery cleared.

[jeremyfelt]

Can reproduce.

First scenario in the description results in 'Create Gallery' view with no images selected. Second scenario results in 'Create Gallery' view with the original images selected.

Question is what the expected behavior should be...

[jeremyfelt]

IMO...

Images should stay selected. It's easy enough to clear the selected set if you want to redo a gallery build. If you were to accidentally hit cancel and lose your selections, that would suck more.

So, results from second scenario would be ideal.

[nacin]

koopersmith is working on smoothing over the selection sharing.

[koopersmith]

Patch improves selection sharing. It will update the relevant parts of the selection while retaining any items that are not applicable in the current view (like videos in the create gallery tab). Generally, the behavior should be sensible.

[lessbloat]

22725.diff​ works for me. +1.

[sabreuse]

The patch works for me

[helenyhou]

Another +1

[markjaquith]

In 23089:

New method of managing media selections. There is now a "master" selection in the background. props koopersmith. fixes #22725

• This especially helps when you switch between insert/gallery and have non-images selected (as galleries don't support non-images).
• The views now act as filters on the "master" selection, instead of having their own selections that get passed around.