Make WordPress Core

Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#22728 closed defect (bug) (fixed)

Insert Media 404 for wpspin_light.gif on subfolder installation

Reported by: n7studios Owned by: nacin
Milestone: 3.5 Priority: normal
Severity: trivial Version: 3.5
Component: Media Keywords: needs-testing close
Focuses: Cc:


Using WordPress 3.5 RC3, my Google Chrome Console reports a 404 error for

However, my site is installed in a sub directory at

To reproduce:

  1. Ensure your browser's console is open to view issues / errors
  2. Create or edit a Page
  3. Click on the Add Media button
  4. Click on the Media Library 'tab' (to the right of Upload Files, below the Insert Media title)
  5. Click on an image
  6. Console says:

GET 404 (Not Found) - load-scripts.php:2

Visiting displays the image as expected.

Change History (7)

#1 @nacin
8 years ago

  • Version set to trunk
.media-sidebar .settings-save-status .spinner {
	background: url(../../wp-admin/images/wpspin_light.gif) no-repeat;

Yeah, we can't do that.

#2 @helenyhou
8 years ago

  • Milestone changed from Awaiting Review to 3.5

Rawr. Let's copy wpspin_light.gif over to wp-includes/images. And maybe just name it wpspin there, because dark doesn't exist anymore, anyway.

Last edited 8 years ago by helenyhou (previous) (diff)

#3 @nacin
8 years ago

In 23023:

Copy wpspin_light to wp-includes as wpspin.gif. Use it in media views. see #22728.

#4 @nacin
8 years ago

  • Keywords needs-testing close added

Can someone verify this on a retina device?

#5 @nacin
8 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 23026:

Move HiDPI block to the bottom of media-views. @media does not provide additional specificity, so the non-retina stuff overrides if the retina rules come first. props lessbloat, fixes #22728.

#6 @TobiasBg
8 years ago

I don't get it. Why is it necessary to copy the image? "wp-includes" and "wp-admin" are in the same level, even in subfolder installs, aren't they? Am I missing something?

#7 @helenyhou
8 years ago

We should never be guessing at paths - this bites us every so often. Folders can be moved if so desired, etc.

Note: See TracTickets for help on using tickets.