Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #22744, comment 58


Ignore:
Timestamp:
09/30/2016 06:07:43 PM (8 years ago)
Author:
flixos90
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #22744, comment 58

    initial v1  
    1 @swissspidy I'm not sure if we should do that. We can to be a 100 percent safe, but the filter removes itself automatically when it's run.
     1@swissspidy I'm not sure if we should do that. We can to be a 100 percent safe, but the filter removes itself automatically when it's run. We might actually add a unit test to verify that the filter removes itself automatically.
    22
    33Otherwise [attachment:22744.12.diff] looks good to me. The one thing that might cause issues is that we completely override the `groupby` clause as this might affect some custom logic which specifies it. We might wanna add another unit test with a `tax_query`, just to be on the safe side (I tested it manually and it works though).