WordPress.org

Make WordPress Core

#22753 closed enhancement (fixed)

Clean up Media sidebar wording

Reported by: markjaquith Owned by: nacin
Milestone: 3.5 Priority: normal
Severity: normal Version: 3.5
Component: Text Changes Keywords: i18n-change has-patch commit
Focuses: Cc:

Description

Now that the Media sidebar is actions, we should look at these two strings: "From URL" and "Featured Image". They don't fit as well. "From URL" is especially confusing.

"Insert from URL" ??
"Set Featured Image" ??

Attachments (2)

22753.diff (687 bytes) - added by markjaquith 17 months ago.
22753.2.diff (1.2 KB) - added by nacin 17 months ago.

Download all attachments as: .zip

Change History (10)

comment:1 DrewAPicture17 months ago

I like both "Insert from URL" and "Set Featured Image".

If we compromise on the casing of the featured image string, we could combine it with the button text, e.g. "Set featured image".

comment:2 nacin17 months ago

A few of the buttons use the same text as the titles, but the two forms of case is deliberate.

comment:3 nacin17 months ago

  • Keywords i18n-change added

markjaquith17 months ago

comment:4 markjaquith17 months ago

  • Owner set to nacin
  • Status changed from new to reviewing

Patched as described. I'll leave this one for Nacin to commit and inform the translators.

nacin17 months ago

comment:6 nacin17 months ago

Patch refreshed (renamed the JS variables too).

comment:7 nacin17 months ago

  • Keywords has-patch commit added

comment:8 nacin17 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 23076:

Media: Final names for the actions in the dialog sidebar: "Insert from URL" and "Set Featured Image" to go with "Insert Media" and "Create Gallery".

Longer strings (such as a translation) looks excellent when it wraps to another line.

props markjaquith, fixes #22753.

Note: See TracTickets for help on using tickets.