WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#22764 closed defect (bug) (fixed)

Taxonomy column on Media Library page is always empty.

Reported by: eddiemoya Owned by: nacin
Milestone: 3.5 Priority: normal
Severity: normal Version: 3.5
Component: Media Keywords: has-patch commit
Focuses: Cc:

Description

When a taxonomy is enabled for attachments in 3.5, a column for that taxonomy is automatically added to the table on the Media Library. However that column fails to ever populate with any of the terms assigned to the attachment.

Attachments (1)

class-wp-media-list-table.patch (821 bytes) - added by eddiemoya 7 years ago.
One-line fix, changes the "if" to an "elseif" as it should be.

Download all attachments as: .zip

Change History (6)

@eddiemoya
7 years ago

One-line fix, changes the "if" to an "elseif" as it should be.

#1 @nacin
7 years ago

  • Milestone changed from Awaiting Review to 3.5
  • Version set to trunk

Great catch.

It looks like this only breaks categories added to attachments, not any taxonomy. (As the second if/elseif/else would set $taxonomy to false, overriding $taxonomy = 'category'.)

#2 @eddiemoya
7 years ago

Correct nacin

For reference see how the same functionality work for the
posts page.

#3 @helenyhou
7 years ago

Patch works for me.

#4 @nacin
7 years ago

  • Keywords has-patch commit added

#5 @nacin
7 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 23081:

Media list table: Fix the categories column, hidden thanks to a typo. props eddiemoya, fixes #22764. see #21240, #21391.

Note: See TracTickets for help on using tickets.