Hidden fields via attachment_fields_to_edit are missing

[nacin]

They were kept separate to be rendered separately, but they never made it there. They should be placed into the chunk of HTML as before.

[nacin]

Tested. Properly prints it on post.php. The dialog properly sends it back to the save-attachment-compat handler.

[nacin]

Test code:

add_filter( 'attachment_fields_to_edit', function( $fields ) {
    $fields['hidden_field_name'] = array( 'input' => 'hidden', 'value' => 'value of field' );
    return $fields;
} );

[koopersmith]

Success. +1.

[koopersmith]

In 23086:

Add hidden fields via attachment_fields_to_edit to the existing compat output. props nacin. fixes #22769.

[kylegilman]

Thanks for fixing this so quickly and I'm sorry I wasn't able to check it sooner, but the hidden fields don't have IDs anymore, they only have names. Previous versions had matching IDs and names.

[nacin]

The IDs weren't exactly valid, since they had brackets in them accidentally.

I don't see this as an issue. A hidden field is good for its name and value, not its ID. If you were doing crazy manipulation on the fly via JS, that JS would no longer be loaded in the two instances of attachment_fields_to_edit, anyway — the new modal and post.php for attachments, versus the old media-upload.php script.