WordPress.org

Make WordPress Core

Opened 17 months ago

Closed 17 months ago

Last modified 17 months ago

#22786 closed defect (bug) (fixed)

Keyboard Shortcuts Broken in Image Crop

Reported by: miqrogroove Owned by: nacin
Milestone: 3.5 Priority: normal
Severity: normal Version: 3.5
Component: Media Keywords: has-patch commit
Focuses: Cc:

Description

There's a list of keyboard shortcuts under Image Crop if you click the help link. The shortcuts work in 3.4.2. Broken while testing 3.5-RC3-23099.

Attachments (1)

22786.diff (1.2 KB) - added by helenyhou 17 months ago.

Download all attachments as: .zip

Change History (9)

comment:1 miqrogroove17 months ago

Chrome 23: Broken
Firefox 16: Working
Opera: N/A

Version 0, edited 17 months ago by miqrogroove (next)

helenyhou17 months ago

comment:2 nacin17 months ago

  • Keywords has-patch commit added
  • Milestone changed from Awaiting Review to 3.5

HELL YES.

comment:4 nacin17 months ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 23106:

Rip keyboard shortcuts out of the image editor help. props helenyhou. fixes #22786.

comment:5 pavelevap17 months ago

Why are shortcuts broken? They were helpfull...

comment:6 helenyhou17 months ago

Since they still work in Firefox, it's probably something Chrome did, not us, and the most helpful one (shift+drag to maintain proportion) actually does work everywhere. Maybe we can further investigate along with just generally making the image editor not suck in 3.6, but for 3.5, I think this is as far as we can go. Plus, five fewer strings to translate :)

comment:7 pavelevap17 months ago

When one shortcut works well - why removing it from Help text? Shortcuts were really handy sometimes and I do not like removing the whole Help text. It would be better to let it be as it is and try to repair in 3.6. Also when it was broken by latest Chrome versions, maybe it can be fixed in the future. But removing only Help text is not a good idea when functionality is still in core.

So, reopen this ticket with "Future Release"?

comment:8 helenyhou17 months ago

No, do not reopen - this ticket is closed on a milestone already. The help text was complete insanity where it was, sliding down and pushing inputs almost off the screen like that - we can do better. This is a power user feature, and is fine without help text that was almost not discoverable in the first place. Leaving the help text there is a promise that it works, and since we can't promise that at this moment, it's better to remove it.

Let's please just allow 3.5 to get out the door and then we can come back to making this whole image editing thing better as a whole. Monkey patching something that sucks is not a good use of time.

Note: See TracTickets for help on using tickets.