Erase Formatting Doesn't erase

[RDall]

In the Content area of a page under the visual test manager of a page if you highlight text click the bold button add italics and cross out. When I I highlight the text and then click the erase format button it only removes the italics and leaves the cross out.

On two other builds I have tested this problem with it turns the text red?

Have tested on two local installs. (one clean to test this issue) and one external install. All using Trunk all the same issue. See screenshot for visual reference.

​http://cl.ly/image/1Y1I1H2u471E

[nacin]

Is this reproducible in 3.4.2?

[RDall]

Screenshot of issue on two different builds.

[helenyhou]

That looks like two different themes to me, probably styling stuff (markup) differently. What's the HTML/Text tab show? Screenshot of that is probably fine.

[nacin]

Related, #21037.

[RDall]

Yes I was able reproduce the problem in 3.4.2 It will remove the bold and the italics but the strike through was not removed. I also checked the html version and all tags were removed but the strike through tag.

​http://cl.ly/image/1X1i2c1K0v0A

[azaozz]

Since we use <del> tag for the Strikethrough button, we need to specify it as removable with the Remove Format button. This can be set in the formats init option. Also added there few of the deprecated elements that are supported with the patched html5 schema.

[azaozz]

#21037 was marked as a duplicate.

[MikeHansenMe]

Tested the patch and it works as expected w/ 3.6-alpha.

[SergeyBiryukov]

#23359 was marked as a duplicate.

[mark-k]

HTML5 defines strong, del and em as having semantic meaning and not a styling one. If all the editor does is styling then it should use style="font-weight:bold" instead of strong etc..

Looking at the patch the deletion of strong, em, del, and ins is wrong as it changes the meaning of the content.

[azaozz]

Yes, best to handle this when upgrading to TinyMCE 4.0. The above patch works but needs more (border cases) testing especially with more complex HTML.

For reference: there is a native contenteditable command editor.execCommand('removeFormat') that typically removes only inline styles. TinyMCE normalizes and extends this, so tags and classes can be removed too.

[RDall]

I'd love if we could get this committed in the trac ticket scrub of 3.7

[RDall]

Tested patch and it works as expected with 3.7 alpha. Is there any other specific things I would need to test to get this ticket closed?

[SergeyBiryukov]

Replying to azaozz:

Yes, best to handle this when upgrading to TinyMCE 4.0.

Related: #24067

[RDall]

FYI I tried this with the new TinyMCE in WordPress 3.9 and it still doesn't erase the strike through abet a minor annoyance but still there. Maybe we should report it to TinyMCE as a bug?

[iseulde]

Asked spocke to consider adding del. I'll keep this ticket updated. It'd be better if this is added to TinyMCE. In case we need to add it ourselves, the 2 year old patch needs a refresh. :)

[iseulde]

Fixed in TinyMCE. :) So this will be fixed in WP soon.
​https://github.com/tinymce/tinymce/commit/a8e99b7ee1d96817e2cdd1291609dcc62a531356

[iseulde]

Fixed in [31700], see #31551.
Also happens fixed for ins now.