Make WordPress Core

Opened 2 years ago

Closed 3 weeks ago

#22799 closed defect (bug) (fixed)

Erase Formatting Doesn't erase

Reported by: RDall Owned by:
Milestone: 4.2 Priority: normal
Severity: normal Version: 3.4
Component: TinyMCE Keywords: upstream
Focuses: Cc:


In the Content area of a page under the visual test manager of a page if you highlight text click the bold button add italics and cross out. When I I highlight the text and then click the erase format button it only removes the italics and leaves the cross out.

On two other builds I have tested this problem with it turns the text red?

Have tested on two local installs. (one clean to test this issue) and one external install. All using Trunk all the same issue. See screenshot for visual reference.


Attachments (2)

Screen Shot 2012-12-06 at 3.40.24 PM.png (127.6 KB) - added by RDall 2 years ago.
Screenshot of issue on two different builds.
22799.patch (969 bytes) - added by azaozz 2 years ago.

Download all attachments as: .zip

Change History (24)

comment:1 @nacin2 years ago

Is this reproducible in 3.4.2?

@RDall2 years ago

Screenshot of issue on two different builds.

comment:2 @helenyhou2 years ago

  • Keywords needs-patch removed

That looks like two different themes to me, probably styling stuff (markup) differently. What's the HTML/Text tab show? Screenshot of that is probably fine.

comment:3 @helenyhou2 years ago

  • Keywords reporter-feedback added

comment:4 @nacin2 years ago

Related, #21037.

comment:5 @RDall2 years ago

Yes I was able reproduce the problem in 3.4.2 It will remove the bold and the italics but the strike through was not removed. I also checked the html version and all tags were removed but the strike through tag.


Last edited 2 years ago by RDall (previous) (diff)

comment:6 @nacin2 years ago

  • Version changed from trunk to 3.4

@azaozz2 years ago

comment:7 @azaozz2 years ago

  • Keywords has-patch needs-testing added; reporter-feedback removed
  • Milestone changed from Awaiting Review to 3.6

Since we use <del> tag for the Strikethrough button, we need to specify it as removable with the Remove Format button. This can be set in the formats init option. Also added there few of the deprecated elements that are supported with the patched html5 schema.

comment:8 @azaozz2 years ago

#21037 was marked as a duplicate.

comment:9 @MikeHansenMe2 years ago

  • Cc mdhansen@… added

Tested the patch and it works as expected w/ 3.6-alpha.

comment:10 @SergeyBiryukov2 years ago

#23359 was marked as a duplicate.

comment:11 @mark-k2 years ago

HTML5 defines strong, del and em as having semantic meaning and not a styling one. If all the editor does is styling then it should use style="font-weight:bold" instead of strong etc..

Looking at the patch the deletion of strong, em, del, and ins is wrong as it changes the meaning of the content.

comment:12 @markjaquith21 months ago

  • Milestone changed from 3.6 to Future Release

comment:13 follow-up: @azaozz21 months ago

Yes, best to handle this when upgrading to TinyMCE 4.0. The above patch works but needs more (border cases) testing especially with more complex HTML.

For reference: there is a native contenteditable command editor.execCommand('removeFormat') that typically removes only inline styles. TinyMCE normalizes and extends this, so tags and classes can be removed too.

comment:14 @RDall20 months ago

I'd love if we could get this committed in the trac ticket scrub of 3.7

comment:15 @RDall19 months ago

Tested patch and it works as expected with 3.7 alpha. Is there any other specific things I would need to test to get this ticket closed?

comment:16 in reply to: ↑ 13 @SergeyBiryukov19 months ago

Replying to azaozz:

Yes, best to handle this when upgrading to TinyMCE 4.0.

Related: #24067

comment:17 @RDall11 months ago

FYI I tried this with the new TinyMCE in WordPress 3.9 and it still doesn't erase the strike through abet a minor annoyance but still there. Maybe we should report it to TinyMCE as a bug?

comment:18 @iseulde3 months ago

  • Keywords needs-refresh added; has-patch needs-testing removed

Asked spocke to consider adding del. I'll keep this ticket updated. It'd be better if this is added to TinyMCE. In case we need to add it ourselves, the 2 year old patch needs a refresh. :)

comment:19 @iseulde3 months ago

  • Keywords needs-refresh removed

Fixed in TinyMCE. :) So this will be fixed in WP soon.

comment:20 @SergeyBiryukov3 months ago

  • Milestone changed from Future Release to 4.2

comment:21 @iseulde3 months ago

  • Keywords upstream added

comment:22 @iseulde3 weeks ago

  • Resolution set to fixed
  • Status changed from new to closed

Fixed in [31700], see #31551.
Also happens fixed for ins now.

Note: See TracTickets for help on using tickets.