WordPress.org

Make WordPress Core

Opened 9 years ago

Closed 9 years ago

#22817 closed defect (bug) (fixed)

New Media: Image isn't auto-selected after uploading featured image

Reported by: johnbillion Owned by: nacin
Milestone: 3.5.1 Priority: normal
Severity: normal Version: 3.5
Component: Media Keywords: has-patch commit fixed-major
Focuses: Cc:

Description

Steps to reproduce:

  • From a post editing screen, click 'Set featured image'.
  • Switch to the 'Upload Files' tab and upload a new image.

Note that the newly upload file isn't automatically selected, leaving the user to scratch their head for a few moments before clicking their newly uploaded image.

Caveat: You can actually upload multiple images in this step. Ideally, this should be disallowed here. Maybe a future enhancement, though.

Attachments (1)

22817.diff (559 bytes) - added by lessbloat 9 years ago.

Download all attachments as: .zip

Change History (12)

#1 @johnbillion
9 years ago

  • Summary changed from New Media: Image isn't auto-selected after uploading to New Media: Image isn't auto-selected after uploading featured image

#2 @nacin
9 years ago

  • Milestone changed from Awaiting Review to 3.5.1

#3 @nacin
9 years ago

I don't know if multiple images needs to be disallowed. They're still getting uploaded to the media library. We could select the first one, or decline to select any when multiple are uploaded at once.

@lessbloat
9 years ago

#4 @lessbloat
9 years ago

22817.diff​ auto selects the file when uploaded from "set featured image", and selects only the first image in the UI when multiple are uploaded.

#5 @adamsilverstein
9 years ago

  • Cc ADAMSILVERSTEIN@… added

this patch corrected the issue for me - verified that uploaded image is now auto-selected in featured image uploader, first image is selected when a group is uploaded;

#6 @kraftbj
9 years ago

  • Keywords has-patch added

#7 @kraftbj
9 years ago

  • Cc bk@… added

#8 @jghazally
9 years ago

Just tested this patch and it worked as expected. :)

#9 @koopersmith
9 years ago

In 23259:

Media: Automatically select uploading attachments in single-select workflows.

The code now automatically selects uploading attachments in all workflows. In a workflow that selects multiple attachments, all attachments added to the upload queue are selected. In a workflow that selects a single attachment (e.g. selecting a featured image), the last attachment added to the upload queue is selected.

see #22817.

#10 @nacin
9 years ago

  • Keywords commit fixed-major added

#11 @nacin
9 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 23270:

Media: Automatically select uploading attachments in single-select workflows.

The code now automatically selects uploading attachments in all workflows. In a workflow that selects multiple attachments, all attachments added to the upload queue are selected. In a workflow that selects a single attachment (e.g. selecting a featured image), the last attachment added to the upload queue is selected.

Merges [23259] to the 3.5 branch.

props koopersmith.
fixes #22817.

Note: See TracTickets for help on using tickets.