Make WordPress Core

Opened 14 years ago

Closed 14 years ago

#22817 closed defect (bug) (fixed)

New Media: Image isn't auto-selected after uploading featured image

Reported by: johnbillion Owned by: nacin
Priority: normal Milestone: 3.5.1
Component: Media Version: 3.5
Severity: normal Keywords: has-patch commit fixed-major
Cc: Focuses:

Description

Steps to reproduce:

  • From a post editing screen, click 'Set featured image'.
  • Switch to the 'Upload Files' tab and upload a new image.

Note that the newly upload file isn't automatically selected, leaving the user to scratch their head for a few moments before clicking their newly uploaded image.

Caveat: You can actually upload multiple images in this step. Ideally, this should be disallowed here. Maybe a future enhancement, though.

Attachments (1)

22817.diff (559 bytes ) - added by lessbloat 14 years ago.

Download all attachments as: .zip

Change History (12)

#1 @johnbillion
14 years ago

  • Summary New Media: Image isn't auto-selected after uploadingNew Media: Image isn't auto-selected after uploading featured image

#2 @nacin
14 years ago

  • Milestone Awaiting Review3.5.1

#3 @nacin
14 years ago

I don't know if multiple images needs to be disallowed. They're still getting uploaded to the media library. We could select the first one, or decline to select any when multiple are uploaded at once.

@lessbloat
14 years ago

#4 @lessbloat
14 years ago

22817.diff​ auto selects the file when uploaded from "set featured image", and selects only the first image in the UI when multiple are uploaded.

#5 @adamsilverstein
14 years ago

  • Cc ADAMSILVERSTEIN@… added

this patch corrected the issue for me - verified that uploaded image is now auto-selected in featured image uploader, first image is selected when a group is uploaded;

#6 @kraftbj
14 years ago

  • Keywords has-patch added

#7 @kraftbj
14 years ago

  • Cc bk@… added

#8 @jghazally
14 years ago

Just tested this patch and it worked as expected. :)

#9 @koopersmith
14 years ago

In 23259:

Media: Automatically select uploading attachments in single-select workflows.

The code now automatically selects uploading attachments in all workflows. In a workflow that selects multiple attachments, all attachments added to the upload queue are selected. In a workflow that selects a single attachment (e.g. selecting a featured image), the last attachment added to the upload queue is selected.

see #22817.

#10 @nacin
14 years ago

  • Keywords commit fixed-major added

#11 @nacin
14 years ago

  • Owner set to nacin
  • Resolutionfixed
  • Status newclosed

In 23270:

Media: Automatically select uploading attachments in single-select workflows.

The code now automatically selects uploading attachments in all workflows. In a workflow that selects multiple attachments, all attachments added to the upload queue are selected. In a workflow that selects a single attachment (e.g. selecting a featured image), the last attachment added to the upload queue is selected.

Merges [23259] to the 3.5 branch.

props koopersmith.
fixes #22817.

Note: See TracTickets for help on using tickets.