WordPress.org

Make WordPress Core

Opened 17 months ago

Closed 17 months ago

Last modified 17 months ago

#22821 closed defect (bug) (fixed)

New media: What on earth does the mystery "Random" checkbox do?

Reported by: johnbillion Owned by: nacin
Milestone: 3.5 Priority: normal
Severity: normal Version: 3.5
Component: Media Keywords: has-patch i18n-change
Focuses: Cc:

Description

No, really. What does it do? This badly needs an explanation.

Evidently it displays the images in a random order, but it could just as well be random columns (seeing as it's positioned immediately below the Columns dropdown) or, due to its complete lack of context, random images.

This may even benefit from being moved up next to the 'Reverse Order' button

Attachments (4)

capture.png (5.6 KB) - added by johnbillion 17 months ago.
22821.patch (484 bytes) - added by johnbillion 17 months ago.
22821-2.diff (459 bytes) - added by CoenJacobs 17 months ago.
Next to text change, also drop context
22821-3.diff (737 bytes) - added by CoenJacobs 17 months ago.
"Link to" text also has to be changed

Download all attachments as: .zip

Change History (12)

johnbillion17 months ago

johnbillion17 months ago

comment:1 johnbillion17 months ago

  • Keywords has-patch i18n-change added

comment:2 westi17 months ago

Note, if we add the word "Order" to the string I don't think we need the context any more as it was only recently added from memory.

comment:3 nacin17 months ago

  • Milestone changed from Awaiting Review to 3.5

I think this is a good change. And westi is right.

comment:4 pavelevap17 months ago

I proposed related change, see #22724. In our localization I added "order" context, but did not realize that it should be also probably done in original. Context can be removed also from the "Random" string (there will be only one now).

Longer string will also cause problems for many more languages, see #22812.

If there will be other string changes in 3.5, could you also resolve related "Describe" and "Describe this image" problem? See http://core.trac.wordpress.org/ticket/22759#comment:16

CoenJacobs17 months ago

Next to text change, also drop context

CoenJacobs17 months ago

"Link to" text also has to be changed

comment:5 CoenJacobs17 months ago

I agree the context string can go. Added 22821-2.diff as a simple patch.

BUT

When we are going to change this text, the "Link To" looks very odd as well. This should be referring to the thumbnails of the gallery, as this is not clear because it is listed under 'Gallery settings'. 22821-3.diff is a quick change for both strings, but should also get some CSS love (I guess) since the elements are not properly aligned anymore due to to length of the string.

comment:6 nacin17 months ago

I'd like to change only "Random" here, for now. I don't think "Link To", is going to be a problem, and also, "Link Thumbnails To" doesn't call all situations. (There are cases when it might be an image larger than a thumbnail.)

While I wouldn't mind flipping the checkbox and the string here, I think http://cl.ly/image/0t452D2b0s1n is very reasonable for longer strings.

comment:7 nacin17 months ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 23135:

Two media gallery string changes, for clarity:

  • 'Random' to 'Random Order', to be clear what it controls.
  • 'Describe this image...' to 'Caption this image...', to be clear it links to the Caption field and not the revived Description field, see [23083].

props johnbillion, pavelevap.
fixes #22821.

comment:8 nacin17 months ago

In 23138:

Two media gallery string changes, for clarity:

  • 'Random' to 'Random Order', to be clear what it controls.
  • 'Describe this image...' to 'Caption this image...', to be clear it links to the Caption field and not the revived Description field, see [23083].

props johnbillion, pavelevap.
fixes #22821.

Merges [23135] to the 3.5 branch.

Note: See TracTickets for help on using tickets.