Make WordPress Core

Opened 11 years ago

Closed 11 years ago

#22825 closed defect (bug) (fixed)

Twenty Twelve: Buttons active status causes 2px shift

Reported by: brianfeister's profile brianfeister Owned by: lancewillett's profile lancewillett
Milestone: 3.6 Priority: normal
Severity: normal Version: 3.5
Component: Bundled Theme Keywords: has-patch commit early
Focuses: Cc:

Description

There was one other location where I saw this, but unfortunately I can only find the behavior in the Twentytwelve buttons right now.

Here is a video of the bug and the fix:
http://dreamstarstudios.com/screencasts/2012-12-08_0226.swf

Attachments (1)

22825.patch (646 bytes) - added by ocean90 11 years ago.

Download all attachments as: .zip

Change History (14)

#1 @SergeyBiryukov
11 years ago

  • Component changed from UI to Bundled Theme

#2 @ocean90
11 years ago

  • Keywords has-patch added
  • Summary changed from Implementation of Bootstrap Buttons Causes 1px Shift to Twenty Twelve: Buttons active status causes 2px shift

@ocean90
11 years ago

#3 @nacin
11 years ago

  • Keywords commit added

#4 @nacin
11 years ago

I think this will need to wait for 3.6 as Twenty Twelve has already been released to the theme directory as 1.1. (It was supposed to wait for 3.5 final, but it got pushed early...)

#5 @nacin
11 years ago

  • Milestone changed from Awaiting Review to Future Release

#6 @lancewillett
11 years ago

@brianfeister Could you please add some more information?

  • Browser version
  • OS version
  • Example URL or steps to repeat in a test install

With display bugs that is essential info to help track this down, fix, and test thoroughly.

#7 follow-up: @ocean90
11 years ago

lancewillet, you saw the screencast?

  • Browser: Firefox, Chrome, Safari, Opera
  • OS: Win, Mac
  • Steps: Press the Post Comment button

#8 in reply to: ↑ 7 @lancewillett
11 years ago

Replying to ocean90:

lancewillet, you saw the screencast?

I didn't see any mention in the screencast of which permalink to test on or which browser / OS combinations. Crucial info! Also: s/lancewillet/lancewillett/ :)

#9 @lancewillett
11 years ago

  • Cc drewstrojny added
  • Keywords ui-feedback added; commit removed

Looking at this again, it *could* be intentional per the original design. I'll check with @drewstrojny.

#10 follow-up: @drewstrojny
11 years ago

Good catch! This is not intentional and I'm on board with the patch.

#11 in reply to: ↑ 10 @lancewillett
11 years ago

  • Keywords commit early added; ui-feedback removed

Replying to drewstrojny:

Good catch! This is not intentional and I'm on board with the patch.

Thanks Drew. I'll get it in after 3.5.

#12 @lancewillett
11 years ago

  • Milestone changed from Future Release to 3.6

#13 @lancewillett
11 years ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In 23426:

Twenty Twelve: fix button active state to avoid a 2px shift, fixes #22825. Props ocean90.

Note: See TracTickets for help on using tickets.