Opened 12 years ago
Closed 12 years ago
#22835 closed defect (bug) (fixed)
link-search-field float (RTL-Arabic)
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 3.5.1 | Priority: | normal |
Severity: | normal | Version: | 3.4.2 |
Component: | RTL | Keywords: | has-patch commit fixed-major |
Focuses: | Cc: |
Description
Link search field should be moved to right
+ General note about URL field.
(Screenshot attached)
Attachments (10)
Change History (30)
#4
in reply to:
↑ 2
@
12 years ago
- Cc r_a_m_i@… added
- Keywords needs-patch added
#6
@
12 years ago
- Keywords has-patch added; needs-patch removed
22835.patch also cleans up some obsolete and redundant styles.
Screenshot: 22835.after.png
#7
@
12 years ago
Also noticed a bug with the search input in Chrome similar to the one in #22935: 22835.chrome-search-input.png.
Appears to be a Chromium bug, fixed two weeks ago: https://codereview.chromium.org/11421088/.
22835.2.patch fixes that as well using ::-webkit-textfield-decoration-container
: 22835.chrome-search-input.2.png.
#8
follow-up:
↓ 10
@
12 years ago
Sergey, can you make the search input box wider? as wide as the URL input bux above?
#10
in reply to:
↑ 8
@
12 years ago
Replying to ramiy:
Sergey, can you make the search input box wider? as wide as the URL input bux above?
Changed for both LTR and RTL in 22835.3.patch. Screenshot: 22835.after.2.png.
And move the X on the top-right corner to the top-left corner.
Also fixed in 22835.3.patch.
#12
@
12 years ago
22835.3.patch looks good, just would request that the ::-webkit-textfield-decoration-container
piece be taken out so we address that universally instead.
#13
@
12 years ago
Done in 22835.4.patch
#15
follow-up:
↓ 16
@
12 years ago
- Keywords commit removed
22835.4.patch makes the input so wide that the spinner is bumped to the next line. I don't think a search field needs to be full-width, let's bring it back to what it has been for now, for 3.5.
Is this a 3.5 regression?