WordPress.org

Make WordPress Core

#22835 closed defect (bug) (fixed)

link-search-field float (RTL-Arabic)

Reported by: rasheed Owned by: nacin
Milestone: 3.5.1 Priority: normal
Severity: normal Version: 3.4.2
Component: RTL Keywords: has-patch commit fixed-major
Focuses: Cc:

Description

Link search field should be moved to right
+ General note about URL field.

(Screenshot attached)

Attachments (10)

link.gif (60.3 KB) - added by rasheed 17 months ago.
22835.patch (1.4 KB) - added by SergeyBiryukov 16 months ago.
22835.after.png (16.4 KB) - added by SergeyBiryukov 16 months ago.
22835.chrome-search-input.png (17.2 KB) - added by SergeyBiryukov 16 months ago.
22835.2.patch (1.5 KB) - added by SergeyBiryukov 16 months ago.
22835.chrome-search-input.2.png (17.1 KB) - added by SergeyBiryukov 16 months ago.
22835.3.patch (1.7 KB) - added by SergeyBiryukov 16 months ago.
22835.after.2.png (16.2 KB) - added by SergeyBiryukov 16 months ago.
22835.4.patch (1.6 KB) - added by SergeyBiryukov 16 months ago.
22835.diff (1.6 KB) - added by helen 16 months ago.

Download all attachments as: .zip

Change History (30)

rasheed17 months ago

comment:1 nacin17 months ago

Is this a 3.5 regression?

comment:2 follow-up: rasheed17 months ago

Same issue also in 3.4.2

comment:3 helenyhou17 months ago

  • Version changed from trunk to 3.4.2

comment:4 in reply to: ↑ 2 ramiy16 months ago

  • Cc r_a_m_i@… added
  • Keywords needs-patch added

Replying to nacin:

Is this a 3.5 regression?

Replying to rasheed:

Same issue also in 3.4.2

The URL alignment was also on 3.4.2, but the search box is 3.5 regression.

Last edited 16 months ago by ramiy (previous) (diff)

comment:5 nacin16 months ago

  • Milestone changed from Awaiting Review to 3.5.1

SergeyBiryukov16 months ago

SergeyBiryukov16 months ago

comment:6 SergeyBiryukov16 months ago

  • Keywords has-patch added; needs-patch removed

22835.patch also cleans up some obsolete and redundant styles.

Screenshot: 22835.after.png

SergeyBiryukov16 months ago

comment:7 SergeyBiryukov16 months ago

Also noticed a bug with the search input in Chrome similar to the one in #22935: 22835.chrome-search-input.png.

Appears to be a Chromium bug, fixed two weeks ago: https://codereview.chromium.org/11421088/.

22835.2.patch fixes that as well using ::-webkit-textfield-decoration-container: 22835.chrome-search-input.2.png.

comment:8 follow-up: ramiy16 months ago

Sergey, can you make the search input box wider? as wide as the URL input bux above?

Last edited 16 months ago by ramiy (previous) (diff)

comment:9 ramiy16 months ago

And move the X on the top-right corner to the top-left corner.

SergeyBiryukov16 months ago

comment:10 in reply to: ↑ 8 SergeyBiryukov16 months ago

Replying to ramiy:

Sergey, can you make the search input box wider? as wide as the URL input bux above?

Changed for both LTR and RTL in 22835.3.patch. Screenshot: 22835.after.2.png.

And move the X on the top-right corner to the top-left corner.

Also fixed in 22835.3.patch.

comment:11 ramiy16 months ago

Looks great!

comment:12 helen16 months ago

22835.3.patch looks good, just would request that the ::-webkit-textfield-decoration-container piece be taken out so we address that universally instead.

SergeyBiryukov16 months ago

comment:14 helen16 months ago

  • Keywords commit added

comment:15 follow-up: nacin16 months ago

  • Keywords commit removed

22835.4.patch makes the input so wide that the spinner is bumped to the next line. I don't think a search field needs to be full-width, let's bring it back to what it has been for now, for 3.5.

helen16 months ago

comment:16 in reply to: ↑ 15 helen16 months ago

Replying to nacin:

I don't think a search field needs to be full-width, let's bring it back to what it has been for now, for 3.5.

22835.diff

comment:17 SergeyBiryukov16 months ago

  • Keywords commit added

22835.diff keeps the current search input width.

comment:18 nacin16 months ago

In 23226:

RTL fixes for internal linking. props SergeyBiryukov, helen. see #22835, for trunk.

comment:19 nacin16 months ago

  • Keywords fixed-major added

comment:20 nacin16 months ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 23274:

RTL fixes for internal linking. props SergeyBiryukov, helen.

merges [23226] to the 3.5 branch.
fixes #22835.

Note: See TracTickets for help on using tickets.