WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #22839, comment 1


Ignore:
Timestamp:
12/09/2012 06:23:33 PM (9 years ago)
Author:
cdog
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #22839, comment 1

    initial v1  
    11[http://api.jquery.com/show/ .show()] restores the display property to whatever it was initially. Because the spinner is a span element, that value will be inline which causes the width and height properties to be ignored conform to the [http://www.w3.org/TR/CSS1/#inline-elements CSS Level 1] specifications.
    22
    3 The spinner is displayed in .widget-title because the float property is used which establishes a new [http://colinaarts.com/articles/the-magic-of-overflow-hidden/ block formatting context], while in .sidebar-none float is set to none.
     3The spinner is displayed in .widget-title because the float property is used which establishes a new [http://colinaarts.com/articles/the-magic-of-overflow-hidden/ block formatting context], while in .sidebar-name float is set to none.
    44
    55One solution would be to use [http://api.jquery.com/css/ .css()] instead of [http://api.jquery.com/show/ .show()] to set the display property to inline-block. Or to make the element to establish a new BFC which requires less changes in code.