WordPress.org
Get WordPress

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #22839, comment 21


Ignore:
Timestamp:
01/08/2013 05:45:48 PM (13 years ago)
Author:
cdog
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #22839, comment 21

    initial v1  
    11Currently, spinners are toggled via .show()/.hide() jQuery methods. But this doesn't seem to work in all cases creating some inconsistencies (mainly when floats are used).
    22
    3 attachment:22839.2.diff introduces the .active class which toggles a spinner when added/removed. The main advantage is that it adds a standard way of toggling a spinner. Another advatage of adding/romoving a class is that it allows more than one property (not only the display property) to get toggled at once if it's needed.
     3attachment:22839.2.diff introduces the .active class which toggles a spinner when added/removed. The main advantage is that it adds a standard way of toggling a spinner. Another advatage of adding/romoving a class is that it allows more than one property to get changed at once (not only display) if it's needed.
    44
    55In Quick Edit mode, the spinner seems to have an unnecessary offset of 10px (removed in patch).