Changes between Initial Version and Version 1 of Ticket #22839, comment 21
- Timestamp:
- 01/08/13 17:45:48 (5 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #22839, comment 21
initial v1 1 1 Currently, spinners are toggled via .show()/.hide() jQuery methods. But this doesn't seem to work in all cases creating some inconsistencies (mainly when floats are used). 2 2 3 attachment:22839.2.diff introduces the .active class which toggles a spinner when added/removed. The main advantage is that it adds a standard way of toggling a spinner. Another advatage of adding/romoving a class is that it allows more than one property (not only the display property) to get toggled at onceif it's needed.3 attachment:22839.2.diff introduces the .active class which toggles a spinner when added/removed. The main advantage is that it adds a standard way of toggling a spinner. Another advatage of adding/romoving a class is that it allows more than one property to get changed at once (not only display) if it's needed. 4 4 5 5 In Quick Edit mode, the spinner seems to have an unnecessary offset of 10px (removed in patch).
