_wpMediaViewsL10n localization variable written to html doc twice in post.php and post-new.php

[gcorne]

The _wpMediaViewsL10n variable is being written to the html response twice in post.php and post-new.php. This is being caused because wp_enqueue_media() is being called twice: 1) wp-admin/includes/media.php 2) wp-admin/edit-form-advanced.php

[nacin]

It's getting called twice deliberately — one for media_buttons (which is generic), one in edit-form-advanced (in case only featured images are supported). It should work just fine if called twice, hence there aren't any crazy checks to avoid it being called more than once.

The double-printing, though, I know I had patched that at one point, but I guess I didn't commit it. This shouldn't be occurring, but the nice thing is this doesn't break anything.

[gcorne]

I should have been more clear that it didn't break anything. I just wanted to make sure that it was known.

[nacin]

It's possible that someone wishes to enqueue media multiple times for separate post IDs on a page. That's not how it is designed to work. Currently, the last enqueue "wins", while the patch that makes the most sense here would block subsequent calls.

[nacin]

In 23214:

Limit the execution of wp_enqueue_media() to once per page. Prevents multiple _wpMediaViewsL10n variables. see #22843.

[nacin]

In 23269:

Limit the execution of wp_enqueue_media() to once per page. Prevents multiple _wpMediaViewsL10n variables.

Merges [23214] to the 3.5 branch.
fixes #22843.