Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#22855 closed defect (bug) (fixed)

Add 3.5 removed files to $_old_files

Reported by: duck_ Owned by: nacin
Milestone: 3.5.1 Priority: normal
Severity: normal Version: 3.5
Component: Upgrade/Install Keywords: has-patch commit
Focuses: Cc:


$ diff -ru --exclude=wp-content . ~/code/wordpress/tags/3.5/
Only in ./wp-admin/images/screenshots: captions-1.png
Only in ./wp-admin/images/screenshots: captions-2.png
Only in ./wp-admin/images/screenshots: flex-header-1.png
Only in ./wp-admin/images/screenshots: flex-header-2.png
Only in ./wp-admin/images/screenshots: flex-header-3.png
Only in ./wp-admin/images/screenshots: flex-header-media-library.png
Only in ./wp-admin/images/screenshots: theme-customizer.png
Only in ./wp-admin/images/screenshots: twitter-embed-1.png
Only in ./wp-admin/images/screenshots: twitter-embed-2.png
Only in ./wp-admin/js: utils.js
Only in ./wp-admin: options-privacy.php
Only in .: wp-app.php
Only in ./wp-includes: class-wp-atom-server.php
Only in ./wp-includes/js/tinymce/themes/advanced/skins/wp_theme: ui.css

Attachments (1)

22855.diff (1.0 KB) - added by duck_ 3 years ago.

Download all attachments as: .zip

Change History (8)

3 years ago

#1 @nacin
3 years ago

I wonder if we should wait for wp-app.php and class-wp-atom-server.php until 3.6. During the 3.5 upgrade, we forced enable_app off. But that doesn't include people who forced it on with a filter, and they'll get a bit of a shell-shock if it suddenly goes away on a point release.

Otherwise, looks good. I think wp-admin/js/utils.min.js also needs to be removed, yeah?

#2 @nacin
3 years ago

  • Component changed from General to Upgrade/Install
  • Keywords commit added

Commit otherwise. Perhaps discuss during the dev chat today what to do?

#3 @markjaquith
3 years ago

Agree. Leave the atom stuff for 3.6. Everything else can go.

#4 @nacin
3 years ago

In 23203:

Remove deleted files on upgrade, including wp-app.php and class-wp-atom-server.php.

props duck_
see #22855
for trunk

#5 @nacin
3 years ago

In 23204:

Correct the deprecated notice in AtomPub's deprecated class. see #22855.

#6 @nacin
3 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 23205:

Remove the now defunct wp-admin/options-privacy.php PHP file on the next core update.

props duck_
fixes #22855
for the 3.5 branch

#7 @nacin
3 years ago

Let's just stick to the PHP file for 3.5, rather than adding unnecessary deletes (in particular, the screenshots, which are large and could take some extra time) in a point release.

Note: See TracTickets for help on using tickets.