WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #22862, comment 58


Ignore:
Timestamp:
08/08/2013 03:16:04 PM (6 years ago)
Author:
rmccue
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #22862, comment 58

    initial v1  
    22> Beyond making the files LESS/SCSS, what does the patching process look like for somebody? Like from figuring out where the problem CSS is to fixing it to making a patch and submitting it.
    33
    4 We can generate source maps with Sass that will [http://bricss.net/post/33788072565/using-sass-source-maps-in-webkit-inspector give a reasonably good output] (and I think Less has similar). For production, we may want to minify the stylesheets, but otherwise, we can also output [https://gist.github.com/rmccue/6153632#file-buttons-css-L58 comments into the CSS] that point back to the source.
     4We can generate source maps with Sass that will [http://bricss.net/post/33788072565/using-sass-source-maps-in-webkit-inspector give a reasonably good output] (and I think Less has similar). ([http://snugug.com/musings/debugging-sass-source-maps This post] may be more accurate on the maps themselves) For production, we may want to minify the stylesheets, but otherwise, we can also output [https://gist.github.com/rmccue/6153632#file-buttons-css-L58 comments into the CSS] that point back to the source.
    55
    66To contribute a patch, they track down the source in SCSS/Less and fix the issue there, while running `grunt watch` or similar, which will automatically rebuild their CSS on the fly. Once it's fixed, patch as normal.