get_page_uri() can produce PHP Warnings when non-WP_Post object instances are passed

[dd32]

A common PHP Warning being posted on the forums includes the following:

Warning: Invalid argument supplied for foreach() in wp-includes/post.php on line 3588

This is being caused by the lazy-loading of the ancestor field, with non-WP_Post instances being passed in.

Although I haven't tracked down how themes are using it, using the following code in the loop to simulate a WP_Post object being converted to a standard StdClass instance duplicates the issue:

var_dump( get_page_uri( (object)(array)$post ) );

The change to fix this seems like an obvious change to me, so I've not yet dug into the reasonings behind themes triggering it.

I've seen the Warning in the wild in a few places, but an example forum thread: ​http://wordpress.org/support/topic/warning-invalid-argument-supplied-for-foreach-in-homeftpublic_htmlwp-incl?

Patch attached, milestone set for review purposes.

[dd32]

Upgrade objects to WP_Post objects if passed in

[nacin]

Definitely a good change. I imagine we'll find random code throughout WP that might need to be updated to call get_post() unconditionally.

[ocean90]

#22945 was marked as a duplicate.

[lukbarros]

it is possible to track who placed this if and when? He can this ai for some other purpose correction.

[SergeyBiryukov]

Replying to lukbarros:

it is possible to track who placed this if and when?

Introduced in [14399].

[nacin]

Seems good.

[georgestephanis]

Is there any chance that someone would pass in an associative array version of the post? I don't expect it, but I don't wear the tin foil hat for nothin'.

Apart from that, the change looks good and sane, +1.

[nacin]

In 1175/tests:

Test for get_page_uri() producing PHP warnings on non-WP_Post post objects. see #22883.

[nacin]

In 23208:

Always call get_post() in get_page_uri() to ensure we have a WP_Post object, which lazy-loads the ancestors this function requires.

props dd32
fixes #22883
Unit tests: [1175/tests]

[nacin]

In 23209:

Always call get_post() in get_page_uri() to ensure we have a WP_Post object, which lazy-loads the ancestors this function requires.

Merges [23208] to the 3.5 branch.
props dd32.
fixes #22883.