WordPress.org

Make WordPress Core

Opened 19 months ago

Closed 12 months ago

Last modified 12 months ago

#22897 closed defect (bug) (fixed)

RTL on plugin information tab

Reported by: ramiy Owned by: nacin
Milestone: 3.6 Priority: normal
Severity: normal Version: 3.5
Component: RTL Keywords: has-patch commit
Focuses: Cc:

Description

The plugin information tab needs a few adjustments RTL adjustments, check out the screenshot.

Attachments (9)

plugin_info.png (136.6 KB) - added by ramiy 19 months ago.
Thickbox RTL support.diff (469 bytes) - added by JDTrower 19 months ago.
Swaps title and close button in Thickbox on Plugin Details box.
Thickbox RTL support-2.diff (500 bytes) - added by JDTrower 19 months ago.
Swaps title and close button in Thickbox on Plugin Details box and moves the FYI box back to being floated right instead of left.
Hebrew Install - 1st Patch Applied.jpg (613.3 KB) - added by JDTrower 19 months ago.
Screen shot with 1st Patch Applied to WordPress
Hebrew Install - 2nd Patch Applied.jpg (613.7 KB) - added by JDTrower 19 months ago.
Screen shot with 2nd Patch Applied to WordPress
Thickbox RTL support-revised.diff (669 bytes) - added by JDTrower 19 months ago.
Revised 2nd patch to include margin fix on H2 tag.
22897.diff (811 bytes) - added by SergeyBiryukov 19 months ago.
22897.2.diff (805 bytes) - added by ocean90 12 months ago.
Refresh
22897.3.diff (1.2 KB) - added by ocean90 12 months ago.

Download all attachments as: .zip

Change History (23)

ramiy19 months ago

JDTrower19 months ago

Swaps title and close button in Thickbox on Plugin Details box.

JDTrower19 months ago

Swaps title and close button in Thickbox on Plugin Details box and moves the FYI box back to being floated right instead of left.

comment:1 follow-up: JDTrower19 months ago

  • Keywords has-patch rtl-feedback ui-feedback added

I have attached two patches. The first patch fixes the Thickbox address bar where the title and the close button are located. This patch swaps the two locations. The second patch, in addition to the fix found in the first patch also moves the For Your Information (FYI) box from the left back to the right. I have tested the fix in WP 3.4.2, WP 3.5, and trunk r23175 and it works in all of them. The patches are patched against trunk.

My personal thought, in LTR languages the FYI box is floated to the right. Thus, it is reasonable to assume that in a RTL language, the FYI box should be floated to the left, as it is in WP 3.5 and trunk (also how it is pictured in the Hebrew screenshot). Therefore, my opinion is to implement the fix found in the first patch and leave the FYI box floated the way it is.

comment:2 JDTrower19 months ago

I forgot to mention that the testing in WP 2.4.2 and WP 3.5 was done in the Hebrew localized version while trunk was tested in the version from wordpress.org SVN.

comment:3 in reply to: ↑ 1 ; follow-up: ramiy19 months ago

Replying to JDTrower:

My personal thought, in LTR languages the FYI box is floated to the right. Thus, it is reasonable to assume that in a RTL language, the FYI box should be floated to the left, as it is in WP 3.5 and trunk (also how it is pictured in the Hebrew screenshot). Therefore, my opinion is to implement the fix found in the first patch and leave the FYI box floated the way it is.

In english and other LTR languages the content aligned to left and the FYI box floated to right. And, as you said, it is reasonable to assume that in a RTL language, the FYI box should be floated to the left. BUT because the content is always in English (and it's aligned to left), the FYI box should be floated to the right.

Remember that there is no local version of the text, it's always in english.

Last edited 19 months ago by ramiy (previous) (diff)

comment:4 in reply to: ↑ 3 ; follow-up: JDTrower19 months ago

Replying to ramiy:

In english and other LTR languages the content aligned to left and the FYI box floated to right. And, as you said, it is reasonable to assume that in a RTL language, the FYI box should be floated to the left. BUT because the content is always in English (and it's aligned to left), the FYI box should be floated to the right.

Remember that there is no local version of the text, it's always in english.

Forgive me for being confused, but it appears to me in the screen shot that you attached that all the text in the FYI box is in Hebrew with the exception of the numbers and the authors name. It's my understanding though (unless I am mistaken), that in Hebrew the Arabic numbers are used to represent money, age, the civil calendar date, and in math. To me this would indicate, that the only non-Hebrew word(s) is the name of the author. I looked up numerous plugins in WP 3.5 localized in Hebrew and everyone of them had Hebrew for everything, Arabic numerals for the numbers, and English words for the name of the author. That being the case, would you not then agree that the box should be floated to the left as I assumed?

Now, if you are referencing the plugin description, then yes, that is in English and the text of the plugin description should be aligned left.

I'll attach a couple of screen shots, one showing the first patch applied and the second screen shot showing the second patch applied.

JDTrower19 months ago

Screen shot with 1st Patch Applied to WordPress

JDTrower19 months ago

Screen shot with 2nd Patch Applied to WordPress

comment:5 in reply to: ↑ 4 ramiy19 months ago

Replying to JDTrower:

When i said that The text is in english i meant to the "Plugin Text" writen by the plugin author (Description, Installation, FAQ, Changelog, ect.), not the FYI.

On your 2nd screenshot (patch applied), you need to remove the margin-left:200px; from the H2 tag.

 #plugin-information h2 {
   margin-right: 200px;
   margin-left: 0;
 }

Besides that, the patch is good.

JDTrower19 months ago

Revised 2nd patch to include margin fix on H2 tag.

comment:6 JDTrower19 months ago

I've uploaded a revised patch to include the margin fix.

SergeyBiryukov19 months ago

comment:7 follow-up: SergeyBiryukov19 months ago

  • Keywords ui-feedback removed

22897.diff:

  • Fixes double float declaration for #TB_closeAjaxWindow in Thickbox RTL support-revised.diff.
  • Doesn't include non-relevant padding or text-align rules.
  • Merges too generic .fyi with #plugin-information .fyi.
  • Removes somes styles that will become obsolete if the FYI box is floated to the right.

However, I'm not sure if the FYI box should always be floated to the right.

Replying to ramiy:

In english and other LTR languages the content aligned to left and the FYI box floated to right. And, as you said, it is reasonable to assume that in a RTL language, the FYI box should be floated to the left. BUT because the content is always in English (and it's aligned to left), the FYI box should be floated to the right.

Some plugins already have descriptions in other languages:
http://wordpress.org/extend/plugins/wwwartlebedevru-typograph/

What if the description is in Hebrew? I guess plugin descriptions might be properly internationalized in the future.

comment:8 in reply to: ↑ 7 ramiy19 months ago

Replying to SergeyBiryukov:

What if the description is in Hebrew? I guess plugin descriptions might be properly internationalized in the future.

For now, 99.9% of the plugins are in english. Never seen a plugin with hebrew discription. In the future, when plugin descriptions will be internationalized, we can change the CSS again. For now the patch will work.

comment:9 SergeyBiryukov19 months ago

  • Milestone changed from Awaiting Review to 3.6

comment:10 ocean9014 months ago

  • Cc ocean90 added

comment:11 nacin12 months ago

  • Keywords commit added; rtl-feedback removed

For now the patch will work.

ocean9012 months ago

Refresh

ocean9012 months ago

comment:12 ocean9012 months ago

22897.3.diff fixes the "This plugin has not been tested" message which was hidden by the FYI box, same for screenshots and code blocks.

@ramiy Could you please check this again? Thanks.

comment:13 nacin12 months ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 24633:

Some RTL changes for the plugin information box.

props JDTrower, SergeyBiryukov, ocean90, ramiy.
fixes #22897.

comment:14 nacin12 months ago

Please re-open if something is wrong.

Note: See TracTickets for help on using tickets.