Don't use arrays when passing to load-scripts.php

[georgestephanis]

A semi-revert of #22757 to take the path less traveled.

Arrays are breaking some installs, let's stop doing it and try a different way.

[Otto42]

The problem isn't the use of the arrays, I think. The problem is really that the brackets of [ ] are not URL encoded.

What's happening most often is that there are rules in an .htaccess file that's directly blocking square brackets in requests. If these were properly URL encoded, then they wouldn't be hitting these rules and PHP would still be treating them properly.

You have to encode brackets as %5B and %5D to be correct with the spec.

[cnorris23]

This was my exact issue earlier, and Otto is correct. There were rules specifically blocking the square brackets. Encoding them, which is technically correct as Otto stated, fixes the issue.

[nacin]

Darn it. I was really close to encoding these, too.

[markjaquith]

Let's get confirmation that encoding does or does not fix the issue on mod_pagespeed systems, as well as whether georgestephanis' patch does or does not fix the issue on mod_pagespeed systems. I think we've confirmed that either solves the issue for Bulletproof Security systems.

[nacin]

Testing without chunking

[nacin]

I did quite a number of tests on a box set up with pagespeed (courtesy of ipstenu) and found that pagespeed is overall very finicky when files change, but that it worked (or didn't) with load=, load[]=, and load%5B%5D=.

According to ipstenu, Dreamhost got maybe a half-dozen of these reports, and whether they break is intermittent at best. A site on DH that I tested worked fine. I suggest they move forward with excluding wp-admin for now.

So, moving forward with 22899.2.diff​.

[nacin]

In 23201:

Encode brackets in the load-scripts.php URL, as these are considered unsafe characters and can be misunderstood. (See RFC 1738.) In particular, a "security" rewrite rule from a plugin blocked URLs with unencoded brackets. fixes #22899 for trunk.

[nacin]

In 23202:

Encode brackets in the load-scripts.php URL, as these are considered unsafe characters and can be misunderstood. (See RFC 1738.) In particular, a "security" rewrite rule from a plugin blocked URLs with unencoded brackets. fixes #22899 for the 3.5 branch.

--Thia and those below, will be ignored--

M script-loader.php